ComposerController::actionSelfUpdate() - Code Metrics - Inspection of "minor" - hiqdev/hidev-composer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53e22b...6229cb )

by Andrii

created 2016-01-14 13:32 UTC

ComposerController::actionSelfUpdate() A

↳ Parent: ComposerController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

/*
 * Composer plugin for HiDev
 *
 * @link      https://github.com/hiqdev/hidev-composer
 * @package   hidev-composer
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015, HiQDev (http://hiqdev.com/)
 */

namespace hidev\composer\controllers;

use Yii;

/**
 * Goal for Composer.
 */
class ComposerController extends \hidev\controllers\CommonController
{
    protected $_before = ['composer.json'];

    public function actionInstall()
    {
        return $this->runActions(['before', 'do-install', 'after']);
    }

    public function actionUpdate()
    {
        return $this->runActions(['before', 'do-update', 'after']);
    }

    public function actionSelfUpdate($version = null)

    {
        return $this->run('self-update', '');
    }

    public function actionDoInstall()
    {
        $dir = Yii::getAlias('@prjdir/vendor');

        return is_dir($dir) ? 0 : $this->run('install');
    }

    public function actionDoUpdate()
    {
        return $this->run('update');
    }

    public function run($command, $dir = null)
    {
        if ($dir === null) {
            $dir = Yii::getAlias('@prjdir');
        }
        $args = [$command, '--ansi'];
        if ($dir) {
            $args[] = '-d';
            $args[] = $dir;
        }
        return $this->passthru('composer', $args);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function getNamespace()
    {
        return @trim(key($this->getConfiguration()->getFile()->get('autoload')['psr-4']), '\\');
    }

    public function getFullName()
    {
        return $this->getConfiguration()->getFullName();
    }

    public function getConfiguration()
    {
        $conf = $this->takeGoal('composer.json');
        $conf->runAction('load');
        return $conf;
    }
}


1			<?php
2
3			/*
4			* Composer plugin for HiDev
5			*
6			* @link https://github.com/hiqdev/hidev-composer
7			* @package hidev-composer
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hidev\composer\controllers;
13
14			use Yii;
15
16			/**
17			* Goal for Composer.
18			*/
19			class ComposerController extends \hidev\controllers\CommonController
20			{
21			protected $_before = ['composer.json'];
22
23			public function actionInstall()
24			{
25			return $this->runActions(['before', 'do-install', 'after']);
26			}
27
28			public function actionUpdate()
29			{
30			return $this->runActions(['before', 'do-update', 'after']);
31			}
32
33			public function actionSelfUpdate($version = null)
			0 ignored issues – show Unused Code introduced 2016-01-14 13:45 UTC by Report Bug Copy Issue Report The parameter `$version` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
34			{
35			return $this->run('self-update', '');
36			}
37
38			public function actionDoInstall()
39			{
40			$dir = Yii::getAlias('@prjdir/vendor');
41
42			return is_dir($dir) ? 0 : $this->run('install');
43			}
44
45			public function actionDoUpdate()
46			{
47			return $this->run('update');
48			}
49
50			public function run($command, $dir = null)
51			{
52			if ($dir === null) {
53			$dir = Yii::getAlias('@prjdir');
54			}
55			$args = [$command, '--ansi'];
56			if ($dir) {
57			$args[] = '-d';
58			$args[] = $dir;
59			}
60			return $this->passthru('composer', $args);
			0 ignored issues – show Documentation introduced 2016-01-14 11:15 UTC by Report Bug Copy Issue Report `$args` is of type `array<integer,?>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			}
62
63			public function getNamespace()
64			{
65			return @trim(key($this->getConfiguration()->getFile()->get('autoload')['psr-4']), '\\');
66			}
67
68			public function getFullName()
69			{
70			return $this->getConfiguration()->getFullName();
71			}
72
73			public function getConfiguration()
74			{
75			$conf = $this->takeGoal('composer.json');
76			$conf->runAction('load');
77			return $conf;
78			}
79			}
80

hiqdev / hidev-composer

Push — master ( 53e22b...6229cb )

ComposerController::actionSelfUpdate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like