Issues in SearchHandler.php (master) - Issues in master - hiqdev/hiapi - Measure and Improve Code Quality continuously with Scrutinizer

Issues (78)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/commands/SearchHandler.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * HiAPI Yii2 base project for building API
 *
 * @link      https://github.com/hiqdev/hiapi
 * @package   hiapi
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiapi\commands;

use hiqdev\DataMapper\Query\Specification;
use hiqdev\DataMapper\Repository\RepositoryInterface;
use hiqdev\DataMapper\Repository\EntityManagerInterface;

/**
 * Class SearchHandler
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class SearchHandler
{
    /**
     * @var EntityManagerInterface
     */
    private $em;

    /**
     * SearchHandler constructor.
     *
     * @param EntityManagerInterface $em
     */
    public function __construct(EntityManagerInterface $em)
    {
        $this->em = $em;
    }

    /**
     * @return Specification
     */
    protected function createSpecification()
    {
        return new Specification();
    }

    /**
     * @param SearchCommand $command
     */
    public function handle(EntityCommandInterface $command)
    {
        $repo = $this->getRepository($command);

        $specification = $this->buildSpecification($command);

        if ($command->count) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return $repo->count($specification);
        }

        return $repo->findAll($specification);
    }

    /**
     * @param EntityCommandInterface|SearchCommand $command
     * @return Specification
     */
    protected function buildSpecification(EntityCommandInterface $command)
    {
        $spec = $this->createSpecification();
        $spec->where(array_merge($command->filter, $command->where));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        if (!$command->count) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            if (strtolower($command->limit) === 'all') {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $command->limit = -1;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            }
            $limit = $command->limit ?? 25;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $spec->limit($limit);
            if ($limit !== -1) {
                $spec->offset((($command->page ?? 0) * $limit) - $limit);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            }
            $spec->with(array_merge($command->include, $command->with));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }

        return $spec;
    }

    /**
     * @param SearchCommand $command
     * @return RepositoryInterface
     */
    protected function getRepository(EntityCommand $command)
    {
        return $this->em->getRepository($command->getEntityClass());
    }
}


1			<?php
2			/**
3			* HiAPI Yii2 base project for building API
4			*
5			* @link https://github.com/hiqdev/hiapi
6			* @package hiapi
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiapi\commands;
12
13			use hiqdev\DataMapper\Query\Specification;
14			use hiqdev\DataMapper\Repository\RepositoryInterface;
15			use hiqdev\DataMapper\Repository\EntityManagerInterface;
16
17			/**
18			* Class SearchHandler
19			*
20			* @author Dmytro Naumenko <[email protected]>
21			*/
22			class SearchHandler
23			{
24			/**
25			* @var EntityManagerInterface
26			*/
27			private $em;
28
29			/**
30			* SearchHandler constructor.
31			*
32			* @param EntityManagerInterface $em
33			*/
34			public function __construct(EntityManagerInterface $em)
35			{
36			$this->em = $em;
37			}
38
39			/**
40			* @return Specification
41			*/
42			protected function createSpecification()
43			{
44			return new Specification();
45			}
46
47			/**
48			* @param SearchCommand $command
49			*/
50			public function handle(EntityCommandInterface $command)
51			{
52			$repo = $this->getRepository($command);
			0 ignored issues – show Compatibility introduced 2019-04-13 09:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$command` of type `object<hiapi\commands\EntityCommandInterface>` is not a sub-type of `object<hiapi\commands\EntityCommand>`. It seems like you assume a concrete implementation of the interface `hiapi\commands\EntityCommandInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
53			$specification = $this->buildSpecification($command);
54
55			if ($command->count) {
			0 ignored issues – show Bug introduced 2019-04-13 09:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `count` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
56			return $repo->count($specification);
57			}
58
59			return $repo->findAll($specification);
60			}
61
62			/**
63			* @param EntityCommandInterface\|SearchCommand $command
64			* @return Specification
65			*/
66			protected function buildSpecification(EntityCommandInterface $command)
67			{
68			$spec = $this->createSpecification();
69			$spec->where(array_merge($command->filter, $command->where));
			0 ignored issues – show Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `filter` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `where` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
70
71			if (!$command->count) {
			0 ignored issues – show Bug introduced 2019-04-13 09:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `count` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
72			if (strtolower($command->limit) === 'all') {
			0 ignored issues – show Bug introduced 2019-04-13 12:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `limit` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
73			$command->limit = -1;
			0 ignored issues – show Bug introduced 2019-04-13 12:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `limit` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
74			}
75			$limit = $command->limit ?? 25;
			0 ignored issues – show Bug introduced 2019-04-13 12:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `limit` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
76			$spec->limit($limit);
77			if ($limit !== -1) {
78			$spec->offset((($command->page ?? 0) * $limit) - $limit);
			0 ignored issues – show Bug introduced 2019-04-13 12:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `page` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
79			}
80			$spec->with(array_merge($command->include, $command->with));
			0 ignored issues – show Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `include` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `with` on the interface `hiapi\commands\EntityCommandInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
81			}
82
83			return $spec;
84			}
85
86			/**
87			* @param SearchCommand $command
88			* @return RepositoryInterface
89			*/
90			protected function getRepository(EntityCommand $command)
91			{
92			return $this->em->getRepository($command->getEntityClass());
93			}
94			}
95

hiqdev / hiapi

Issues (78)

Security Analysis not enabled

src/commands/SearchHandler.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like