BlacklistMiddleware::isForbidden() - Code Metrics - Inspection of "Added new request processing (moved in from legacy..." - hiqdev/hiapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9a342a...a162ae )

by Andrii

created 2020-03-12 13:08 UTC

BlacklistMiddleware::isForbidden() A

↳ Parent: BlacklistMiddleware

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace hiapi\Core\Http\Psr15\Middleware;

use hiapi\exceptions\NotAuthenticatedException;
use hiapi\legacy\lib\deps\dbc;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

class BlacklistMiddleware implements MiddlewareInterface
{
    private $dbc;

    public function __construct(dbc $dbc)
    {
        $this->dbc = $dbc;
    }

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $ip = $this->getIp($request);
        if ($this->isForbidden($ip)) {
            throw new NotAuthenticatedException('Forbidden IP: ' . $ip);
        }

        return $handler->handle($request);
    }

    private function isForbidden(string $ip): bool
    {
        $qip = $this->dbc->quote($ip);
        $found = $this->dbc->value("
            SELECT      1
            FROM        blacklisted
            WHERE       client_id = root_client_id()
                    AND type_id = ztype_id('blacklisted,ip')
                    AND state_id = state_id('blacklisted,ok')
                    AND str2inet(name) >>= str2inet($qip)
        ");
        return (bool)$found;
    }

    private function getIp(ServerRequestInterface $request): string
    {
        $ip = $request->getAttribute(ClientIpMiddleware::ATTRIBUTE_NAME);
        if (!empty($ip)) {
            return $ip;
        }

        $params = $request->getServerParams();

        return $params['REMOTE_ADDR'] ?? '';
    }
}


1			<?php
2
3			namespace hiapi\Core\Http\Psr15\Middleware;
4
5			use hiapi\exceptions\NotAuthenticatedException;
6			use hiapi\legacy\lib\deps\dbc;
7			use Psr\Http\Message\ResponseInterface;
8			use Psr\Http\Message\ServerRequestInterface;
9			use Psr\Http\Server\MiddlewareInterface;
10			use Psr\Http\Server\RequestHandlerInterface;
11
12			class BlacklistMiddleware implements MiddlewareInterface
13			{
14			private $dbc;
15
16			public function __construct(dbc $dbc)
17			{
18			$this->dbc = $dbc;
19			}
20
21			public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
22			{
23			$ip = $this->getIp($request);
24			if ($this->isForbidden($ip)) {
25			throw new NotAuthenticatedException('Forbidden IP: ' . $ip);
26			}
27
28			return $handler->handle($request);
29			}
30
31			private function isForbidden(string $ip): bool
32			{
33			$qip = $this->dbc->quote($ip);
34			$found = $this->dbc->value("
35			SELECT 1
36			FROM blacklisted
37			WHERE client_id = root_client_id()
38			AND type_id = ztype_id('blacklisted,ip')
39			AND state_id = state_id('blacklisted,ok')
40			AND str2inet(name) >>= str2inet($qip)
41			");
42			return (bool)$found;
43			}
44
45			private function getIp(ServerRequestInterface $request): string
46			{
47			$ip = $request->getAttribute(ClientIpMiddleware::ATTRIBUTE_NAME);
48			if (!empty($ip)) {
49			return $ip;
50			}
51
52			$params = $request->getServerParams();
53
54			return $params['REMOTE_ADDR'] ?? '';
55			}
56			}
57

hiqdev / hiapi

Push — master ( 9a342a...a162ae )

BlacklistMiddleware::isForbidden() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like