hiapi\query\Specification

Complexity

Total Complexity

8

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	requestRelation()	0	4	1
A	applyTo()	0	12	3
A	applyWhereTo()	0	10	4

<?php
/**
 * HiAPI Yii2 base project for building API
 *
 * @link      https://github.com/hiqdev/hiapi
 * @package   hiapi
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiapi\query;

use yii\db\QueryTrait;

class Specification
{
    use QueryTrait;

    public $requestedRelations = [];

    public function requestRelation($name)
    {
        $this->requestedRelations[$name] = true; // todo: specification for relation
    }

    /**
     * @param Query $query
     * @return Query
     */
    public function applyTo($query)
    {
        if ($this->where) {
            $this->applyWhereTo($query);
        }

        if ($this->limit) {
            $query->limit($this->limit);
        }

        return $query;
    }

    /**
     * @param Query $query
     */
    public function applyWhereTo($query)
    {
        foreach ($this->where as $key => $value) {

The expression $this->where of type string|array is not guaranteed to be traversable. How about adding an additional type check?

            foreach ($query->getFields() as $field) {
                if ($field->isApplicable($key)) {
                    $query->andWhere($field->buildCondition($value));
                }
            }
        }
    }
}