RequestAwareTrait::loadFromRequest() - Code Metrics - hiqdev/hiapi - Measure and Improve Code Quality continuously with Scrutinizer

RequestAwareTrait::loadFromRequest() A
last analyzed 2021-06-11 17:48 UTC

↳ Parent: RequestAwareTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
c	0
b	0
f	0
rs	10
cc	2
nc	2
nop	1

<?php

namespace hiapi\commands;

use yii\base\Model;
use yii\base\Request;

/**
 * Trait RequestAwareTrait
 *
 * @package hiapi\commands
 * @property Model $this
 */
trait RequestAwareTrait
{
    public function loadFromRequest(\yii\web\Request $request)
    {
        $this->load($this->getRequestData($request), '');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->validate();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->hasErrors() ? $this->getErrors() : null;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getRequestData(\yii\web\Request $request)
    {
        $get = $request->get();
        $post = $request->post();

        return array_merge($get, $post);
    }
}


1			<?php
2
3			namespace hiapi\commands;
4
5			use yii\base\Model;
6			use yii\base\Request;
7
8			/**
9			* Trait RequestAwareTrait
10			*
11			* @package hiapi\commands
12			* @property Model $this
13			*/
14			trait RequestAwareTrait
15			{
16			public function loadFromRequest(\yii\web\Request $request)
17			{
18			$this->load($this->getRequestData($request), '');
			0 ignored issues – show Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report It seems like `load()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			$this->validate();
			0 ignored issues – show Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report It seems like `validate()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20
21			return $this->hasErrors() ? $this->getErrors() : null;
			0 ignored issues – show Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report It seems like `hasErrors()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-05-04 13:47 UTC by Report Bug Copy Issue Report It seems like `getErrors()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			}
23
24			public function getRequestData(\yii\web\Request $request)
25			{
26			$get = $request->get();
27			$post = $request->post();
28
29			return array_merge($get, $post);
30			}
31			}
32

hiqdev / hiapi

RequestAwareTrait::loadFromRequest() A last analyzed 2021-06-11 17:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RequestAwareTrait::loadFromRequest() A
last analyzed 2021-06-11 17:48 UTC