PasswordValidator::validateAttribute() - Code Metrics - Inspection of "Added `inlineFor()` in login and password validato..." - hiqdev/hiam-mrdp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 17af2a...d4404d )

by Andrii

created 2019-06-20 13:49 UTC

PasswordValidator::validateAttribute() A

↳ Parent: PasswordValidator

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	4
nc	3
nop	2

<?php

namespace hiam\mrdp\validators;

use hiam\validators\PasswordValidatorInterface;
use Yii;
use yii\base\Model;
use yii\validators\Validator;

class PasswordValidator extends Validator implements PasswordValidatorInterface
{
    /**
     * @var string login attribute name
     */
    public $loginAttribute = 'login';

    /**
     * @var string password attribute name
     */
    public $passwordAttribute = 'current_password';

    public function init()
    {
        parent::init();
        if ($this->message !== null) {
            return;
        }
        $this->message = Yii::t('hiam', 'The current password is incorrect');
    }

    /**
     * {@inheritdoc}
     */
    public function validateAttribute($model, $attribute)
    {
        if ($model->{$this->loginAttribute} && $model->{$this->passwordAttribute}) {
            $valid = Yii::$app->db->createCommand("
                    SELECT      zc.obj_id
                    FROM        zclient zc
                    WHERE       zc.state_id = ANY(state_ids('client', 'ok,active,new'))
                                AND NOT check_password('', zc.password)
                                AND login = :login AND check_password(:password, zc.password)
                ")->bindValues([':login' => $model->{$this->loginAttribute}, ':password' => $model->{$this->passwordAttribute}])->queryScalar();
            if (!$valid) {
                $this->addError($model, $attribute, $this->message);
            }
        }
    }

    public function inlineFor(Model $model): \Closure
    {
        return function (string $attribute) use ($model) {
            $this->validateAttribute($model, $attribute);
        };
    }
}


1			<?php
2
3			namespace hiam\mrdp\validators;
4
5			use hiam\validators\PasswordValidatorInterface;
6			use Yii;
7			use yii\base\Model;
8			use yii\validators\Validator;
9
10			class PasswordValidator extends Validator implements PasswordValidatorInterface
11			{
12			/**
13			* @var string login attribute name
14			*/
15			public $loginAttribute = 'login';
16
17			/**
18			* @var string password attribute name
19			*/
20			public $passwordAttribute = 'current_password';
21
22			public function init()
23			{
24			parent::init();
25			if ($this->message !== null) {
26			return;
27			}
28			$this->message = Yii::t('hiam', 'The current password is incorrect');
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function validateAttribute($model, $attribute)
35			{
36			if ($model->{$this->loginAttribute} && $model->{$this->passwordAttribute}) {
37			$valid = Yii::$app->db->createCommand("
38			SELECT zc.obj_id
39			FROM zclient zc
40			WHERE zc.state_id = ANY(state_ids('client', 'ok,active,new'))
41			AND NOT check_password('', zc.password)
42			AND login = :login AND check_password(:password, zc.password)
43			")->bindValues([':login' => $model->{$this->loginAttribute}, ':password' => $model->{$this->passwordAttribute}])->queryScalar();
44			if (!$valid) {
45			$this->addError($model, $attribute, $this->message);
46			}
47			}
48			}
49
50			public function inlineFor(Model $model): \Closure
51			{
52			return function (string $attribute) use ($model) {
53			$this->validateAttribute($model, $attribute);
54			};
55			}
56			}
57

hiqdev / hiam-mrdp

Push — master ( 17af2a...d4404d )

PasswordValidator::validateAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like