OutputDir::getOutputDir() - Code Metrics - Inspection of "Fixed taking proper dirname depth" - hiqdev/composer-config-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 77a8ea...8a6a58 )

by Andrii

created 2019-07-25 17:59 UTC

OutputDir::getOutputDir() A

↳ Parent: OutputDir

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	1
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
nc	1
nop	0

<?php
/**
 * Composer plugin for config assembling
 *
 * @link      https://github.com/hiqdev/composer-config-plugin
 * @package   composer-config-plugin
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\composer\config;

/**
 * Output Dir class.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class OutputDir
{
    /**
     * @var string path to output assembled configs
     */
    protected $dir;

    public function __construct($outputDir = null)
    {
        $this->setOutputDir($outputDir);

    }

    public function setOutputDir($outputDir)
    {
        var_dump(__METHOD__, $outputDir);die;

        $this->outputDir = $outputDir ?: static::findOutputDir();
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function getOutputDir(): string
    {
        return $this->outputDir;
    }

    /**
     * Returns default output dir.
     * @param string $vendor path to vendor dir
     * @return string
     */
    public static function findOutputDir($vendor = null)
    {
        if ($vendor) {
            $dir = $vendor . '/hiqdev/' . basename(dirname(__DIR__));
        } else {
            $dir = \dirname(__DIR__);
        }

        return $dir . static::OUTPUT_DIR_SUFFIX;

    }

    /**
     * Returns full path to assembled config file.
     * @param string $filename name of config
     * @param string $vendor path to vendor dir
     * @return string absolute path
     */
    public static function path($filename, $vendor = null)
    {
        return static::findOutputDir($vendor) . DIRECTORY_SEPARATOR . $filename . '.php';
    }

    public function getOutputPath($name)
    {
        return $this->outputDir . DIRECTORY_SEPARATOR . $name . '.php';
    }
}


1			<?php
2			/**
3			* Composer plugin for config assembling
4			*
5			* @link https://github.com/hiqdev/composer-config-plugin
6			* @package composer-config-plugin
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2016-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\composer\config;
12
13			/**
14			* Output Dir class.
15			*
16			* @author Andrii Vasyliev <[email protected]>
17			*/
18			class OutputDir
19			{
20			/**
21			* @var string path to output assembled configs
22			*/
23			protected $dir;
24
25			public function __construct($outputDir = null)
26			{
27			$this->setOutputDir($outputDir);
28
29			}
30
31			public function setOutputDir($outputDir)
32			{
33			var_dump(__METHOD__, $outputDir);die;
			0 ignored issues – show Best Practice introduced 2019-07-25 18:09 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Security Debugging Code introduced 2019-07-25 18:09 UTC by Report Bug Copy Issue Report `var_dump(__METHOD__, $outputDir)` looks like debug code. Are you sure you do not want to remove it? Loading history...
34			$this->outputDir = $outputDir ?: static::findOutputDir();
			0 ignored issues – show Unused Code introduced 2019-07-25 18:09 UTC by Report Bug Copy Issue Report `$this->outputDir = $outp...static::findOutputDir()` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
35			}
36
37			public function getOutputDir(): string
38			{
39			return $this->outputDir;
40			}
41
42			/**
43			* Returns default output dir.
44			* @param string $vendor path to vendor dir
45			* @return string
46			*/
47			public static function findOutputDir($vendor = null)
48			{
49			if ($vendor) {
50			$dir = $vendor . '/hiqdev/' . basename(dirname(__DIR__));
51			} else {
52			$dir = \dirname(__DIR__);
53			}
54
55			return $dir . static::OUTPUT_DIR_SUFFIX;
			0 ignored issues – show Bug introduced 2019-07-25 18:09 UTC by Report Bug Copy Issue Report The constant `hiqdev\composer\config\O...tDir::OUTPUT_DIR_SUFFIX` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
56			}
57
58			/**
59			* Returns full path to assembled config file.
60			* @param string $filename name of config
61			* @param string $vendor path to vendor dir
62			* @return string absolute path
63			*/
64			public static function path($filename, $vendor = null)
65			{
66			return static::findOutputDir($vendor) . DIRECTORY_SEPARATOR . $filename . '.php';
67			}
68
69			public function getOutputPath($name)
70			{
71			return $this->outputDir . DIRECTORY_SEPARATOR . $name . '.php';
72			}
73			}
74

hiqdev / composer-config-plugin

Push — master ( 77a8ea...8a6a58 )

OutputDir::getOutputDir() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like