hiqdev\composer\config\configs\ConfigFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	create()	0	8	2

<?php
/**
 * Composer plugin for config assembling
 *
 * @link      https://github.com/hiqdev/composer-config-plugin
 * @package   composer-config-plugin
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\composer\config\configs;

use hiqdev\composer\config\Builder;

/**
 * Config factory creates Config object of proper class
 * according to config name (and mayby other options later).
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class ConfigFactory
{
    private static $loaders;

The private property $loaders is not used, and could be removed.

    private static $knownTypes = [
        '__rebuild'     => Rebuild::class,
        '__files'       => System::class,
        'aliases'       => System::class,
        'extensions'    => System::class,
        'params'        => Params::class,
        'defines'       => Defines::class,
    ];

    /**
     * @return Config
     */
    public static function create(Builder $builder, string $name)
    {
        $class = isset(static::$knownTypes[$name])

Since $knownTypes is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $knownTypes to at least protected.

            ? static::$knownTypes[$name]
            : Config::class
        ;

        return new $class($builder, $name);
    }
}