Complex classes like Plugin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Plugin, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
29 | class Plugin implements PluginInterface, EventSubscriberInterface |
||
30 | { |
||
31 | const YII2_PACKAGE_TYPE = 'yii2-extension'; |
||
32 | const EXTRA_OPTION_NAME = 'config-plugin'; |
||
33 | |||
34 | /** |
||
35 | * @var PackageInterface[] the array of active composer packages |
||
36 | */ |
||
37 | protected $packages; |
||
38 | |||
39 | /** |
||
40 | * @var string absolute path to the package base directory |
||
41 | */ |
||
42 | protected $baseDir; |
||
43 | |||
44 | /** |
||
45 | * @var string absolute path to vendor directory |
||
46 | */ |
||
47 | protected $vendorDir; |
||
48 | |||
49 | /** |
||
50 | * @var Filesystem utility |
||
51 | */ |
||
52 | protected $filesystem; |
||
53 | |||
54 | /** |
||
55 | * @var array config name => list of files |
||
56 | */ |
||
57 | protected $files = [ |
||
58 | 'dotenv' => [], |
||
59 | 'defines' => [], |
||
60 | 'params' => [], |
||
61 | ]; |
||
62 | |||
63 | /** |
||
64 | * @var array package name => configs as listed in `composer.json` |
||
65 | */ |
||
66 | protected $originalFiles = []; |
||
67 | |||
68 | protected $aliases = []; |
||
69 | |||
70 | protected $extensions = []; |
||
71 | |||
72 | /** |
||
73 | * @var array array of not yet merged params |
||
74 | */ |
||
75 | protected $rawParams = []; |
||
76 | |||
77 | /** |
||
78 | * @var Composer instance |
||
79 | */ |
||
80 | protected $composer; |
||
81 | |||
82 | /** |
||
83 | * @var IOInterface |
||
84 | */ |
||
85 | public $io; |
||
86 | |||
87 | /** |
||
88 | * Initializes the plugin object with the passed $composer and $io. |
||
89 | * @param Composer $composer |
||
90 | * @param IOInterface $io |
||
91 | */ |
||
92 | 2 | public function activate(Composer $composer, IOInterface $io) |
|
97 | |||
98 | /** |
||
99 | * Returns list of events the plugin is subscribed to. |
||
100 | * @return array list of events |
||
101 | */ |
||
102 | 1 | public static function getSubscribedEvents() |
|
110 | |||
111 | /** |
||
112 | * This is the main function. |
||
113 | * @param Event $event |
||
114 | */ |
||
115 | public function onPostAutoloadDump(Event $event) |
||
130 | |||
131 | protected function initAutoload() |
||
142 | |||
143 | protected function scanPackages() |
||
151 | |||
152 | /** |
||
153 | * Scans the given package and collects extensions data. |
||
154 | * @param PackageInterface $package |
||
155 | */ |
||
156 | protected function processPackage(CompletePackageInterface $package) |
||
183 | |||
184 | protected function loadDotEnv(RootPackageInterface $package) |
||
191 | |||
192 | /** |
||
193 | * Adds given files to the list of files to be processed. |
||
194 | * Prepares `defines` in reversed order (outer package first) because |
||
195 | * constants cannot be redefined. |
||
196 | * @param CompletePackageInterface $package |
||
197 | * @param array $files |
||
198 | */ |
||
199 | protected function addFiles(CompletePackageInterface $package, array $files) |
||
219 | |||
220 | /** |
||
221 | * Collects package aliases. |
||
222 | * @param CompletePackageInterface $package |
||
223 | * @return array collected aliases |
||
224 | */ |
||
225 | protected function collectAliases(CompletePackageInterface $package) |
||
240 | |||
241 | /** |
||
242 | * Prepare aliases. |
||
243 | * @param PackageInterface $package |
||
244 | * @param string 'psr-0' or 'psr-4' |
||
245 | * @return array |
||
246 | */ |
||
247 | protected function prepareAliases(PackageInterface $package, $psr, $dev = false) |
||
271 | |||
272 | /** |
||
273 | * Builds path inside of a package. |
||
274 | * @param PackageInterface $package |
||
275 | * @param mixed $path can be absolute or relative |
||
276 | * @return string absolute paths will stay untouched |
||
277 | */ |
||
278 | public function preparePath(PackageInterface $package, $path) |
||
298 | |||
299 | /** |
||
300 | * Sets [[packages]]. |
||
301 | * @param PackageInterface[] $packages |
||
302 | */ |
||
303 | 2 | public function setPackages(array $packages) |
|
307 | |||
308 | /** |
||
309 | * Gets [[packages]]. |
||
310 | * @return \Composer\Package\PackageInterface[] |
||
311 | */ |
||
312 | 1 | public function getPackages() |
|
320 | |||
321 | /** |
||
322 | * Plain list of all project dependencies (including nested) as provided by composer. |
||
323 | * The list is unordered (chaotic, can be different after every update). |
||
324 | */ |
||
325 | protected $plainList = []; |
||
326 | |||
327 | /** |
||
328 | * Ordered list of package in form: package => depth |
||
329 | * For order description @see findPackages. |
||
330 | */ |
||
331 | protected $orderedList = []; |
||
332 | |||
333 | /** |
||
334 | * Returns ordered list of packages: |
||
335 | * - listed earlier in the composer.json will get earlier in the list |
||
336 | * - childs before parents. |
||
337 | * @return \Composer\Package\PackageInterface[] |
||
338 | */ |
||
339 | public function findPackages() |
||
356 | |||
357 | /** |
||
358 | * Iterates through package dependencies. |
||
359 | * @param PackageInterface $package to iterate |
||
360 | * @param bool $includingDev process development dependencies, defaults to not process |
||
361 | */ |
||
362 | protected function iteratePackage(PackageInterface $package, $includingDev = false) |
||
388 | |||
389 | /** |
||
390 | * Iterates dependencies of the given package. |
||
391 | * @param PackageInterface $package |
||
392 | * @param bool $dev which dependencies to iterate: true - dev, default - general |
||
393 | */ |
||
394 | protected function iterateDependencies(PackageInterface $package, $dev = false) |
||
410 | |||
411 | protected function showDepsTree() |
||
426 | |||
427 | protected $colors = ['red', 'green', 'yellow', 'cyan', 'magenta', 'blue']; |
||
428 | |||
429 | /** |
||
430 | * Get absolute path to package base dir. |
||
431 | * @return string |
||
432 | */ |
||
433 | public function getBaseDir() |
||
441 | |||
442 | /** |
||
443 | * Get absolute path to composer vendor dir. |
||
444 | * @return string |
||
445 | */ |
||
446 | public function getVendorDir() |
||
455 | |||
456 | /** |
||
457 | * Getter for filesystem utility. |
||
458 | * @return Filesystem |
||
459 | */ |
||
460 | public function getFilesystem() |
||
468 | } |
||
469 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.