Complex classes like Plugin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Plugin, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
29 | class Plugin implements PluginInterface, EventSubscriberInterface |
||
30 | { |
||
31 | const YII2_PACKAGE_TYPE = 'yii2-extension'; |
||
32 | const EXTRA_OPTION_NAME = 'config-plugin'; |
||
33 | |||
34 | /** |
||
35 | * @var PackageInterface[] the array of active composer packages |
||
36 | */ |
||
37 | protected $packages; |
||
38 | |||
39 | /** |
||
40 | * @var string absolute path to the package base directory |
||
41 | */ |
||
42 | protected $baseDir; |
||
43 | |||
44 | /** |
||
45 | * @var string absolute path to vendor directory |
||
46 | */ |
||
47 | protected $vendorDir; |
||
48 | |||
49 | /** |
||
50 | * @var Filesystem utility |
||
51 | */ |
||
52 | protected $filesystem; |
||
53 | |||
54 | /** |
||
55 | * @var array config name => list of files |
||
56 | */ |
||
57 | protected $files = [ |
||
58 | 'dotenv' => [], |
||
59 | 'defines' => [], |
||
60 | 'params' => [], |
||
61 | ]; |
||
62 | |||
63 | /** |
||
64 | * @var array package name => configs as listed in `composer.json` |
||
65 | */ |
||
66 | protected $originalFiles = []; |
||
67 | |||
68 | protected $aliases = []; |
||
69 | |||
70 | protected $extensions = []; |
||
71 | |||
72 | /** |
||
73 | * @var array array of not yet merged params |
||
74 | */ |
||
75 | protected $rawParams = []; |
||
76 | |||
77 | /** |
||
78 | * @var Composer instance |
||
79 | */ |
||
80 | protected $composer; |
||
81 | |||
82 | /** |
||
83 | * @var IOInterface |
||
84 | */ |
||
85 | public $io; |
||
86 | |||
87 | /** |
||
88 | * Initializes the plugin object with the passed $composer and $io. |
||
89 | * @param Composer $composer |
||
90 | * @param IOInterface $io |
||
91 | */ |
||
92 | 2 | public function activate(Composer $composer, IOInterface $io) |
|
97 | |||
98 | /** |
||
99 | * Returns list of events the plugin is subscribed to. |
||
100 | * @return array list of events |
||
101 | */ |
||
102 | 1 | public static function getSubscribedEvents() |
|
103 | { |
||
104 | return [ |
||
105 | 1 | ScriptEvents::POST_AUTOLOAD_DUMP => [ |
|
106 | ['onPostAutoloadDump', 0], |
||
107 | ], |
||
108 | ]; |
||
109 | } |
||
110 | |||
111 | /** |
||
112 | * This is the main function. |
||
113 | * @param Event $event |
||
114 | */ |
||
115 | public function onPostAutoloadDump(Event $event) |
||
130 | |||
131 | protected function initAutoload() |
||
135 | |||
136 | protected function scanPackages() |
||
137 | { |
||
138 | foreach ($this->getPackages() as $package) { |
||
139 | if ($package instanceof CompletePackageInterface) { |
||
140 | $this->processPackage($package); |
||
141 | } |
||
142 | } |
||
143 | } |
||
144 | |||
145 | /** |
||
146 | * Scans the given package and collects extensions data. |
||
147 | * @param PackageInterface $package |
||
148 | */ |
||
149 | protected function processPackage(CompletePackageInterface $package) |
||
150 | { |
||
151 | $extra = $package->getExtra(); |
||
152 | $files = isset($extra[self::EXTRA_OPTION_NAME]) ? $extra[self::EXTRA_OPTION_NAME] : null; |
||
153 | $this->originalFiles[$package->getPrettyName()] = $files; |
||
154 | |||
155 | if ($package->getType() !== self::YII2_PACKAGE_TYPE && is_null($files)) { |
||
156 | return; |
||
157 | } |
||
158 | |||
159 | if (is_array($files)) { |
||
160 | $this->addFiles($package, $files); |
||
161 | } |
||
162 | if ($package instanceof RootPackageInterface) { |
||
163 | $this->loadDotEnv($package); |
||
164 | } |
||
165 | |||
166 | $aliases = $this->collectAliases($package); |
||
167 | $this->aliases = array_merge($this->aliases, $aliases); |
||
168 | |||
169 | $this->extensions[$package->getPrettyName()] = array_filter([ |
||
170 | 'name' => $package->getPrettyName(), |
||
171 | 'version' => $package->getVersion(), |
||
172 | 'reference' => $package->getSourceReference() ?: $package->getDistReference(), |
||
173 | 'aliases' => $aliases, |
||
174 | ]); |
||
175 | } |
||
176 | |||
177 | protected function loadDotEnv(RootPackageInterface $package) |
||
178 | { |
||
179 | $path = $this->preparePath($package, '.env'); |
||
180 | if (file_exists($path) && class_exists('Dotenv\Dotenv')) { |
||
181 | array_push($this->files['dotenv'], $path); |
||
182 | } |
||
183 | } |
||
184 | |||
185 | /** |
||
186 | * Adds given files to the list of files to be processed. |
||
187 | * Prepares `defines` in reversed order (outer package first) because |
||
188 | * constants cannot be redefined. |
||
189 | * @param CompletePackageInterface $package |
||
190 | * @param array $files |
||
191 | */ |
||
192 | protected function addFiles(CompletePackageInterface $package, array $files) |
||
193 | { |
||
194 | foreach ($files as $name => $paths) { |
||
195 | $paths = (array) $paths; |
||
196 | if ($name === 'defines') { |
||
197 | $paths = array_reverse($paths); |
||
198 | } |
||
199 | foreach ($paths as $path) { |
||
200 | if (!isset($this->files[$name])) { |
||
201 | $this->files[$name] = []; |
||
202 | } |
||
203 | $path = $this->preparePath($package, $path); |
||
204 | if ($name === 'defines') { |
||
205 | array_unshift($this->files[$name], $path); |
||
206 | } else { |
||
207 | array_push($this->files[$name], $path); |
||
208 | } |
||
209 | } |
||
210 | } |
||
211 | } |
||
212 | |||
213 | /** |
||
214 | * Collects package aliases. |
||
215 | * @param CompletePackageInterface $package |
||
216 | * @return array collected aliases |
||
217 | */ |
||
218 | protected function collectAliases(CompletePackageInterface $package) |
||
219 | { |
||
220 | $aliases = array_merge( |
||
221 | $this->prepareAliases($package, 'psr-0'), |
||
222 | $this->prepareAliases($package, 'psr-4') |
||
223 | ); |
||
224 | if ($package instanceof RootPackageInterface) { |
||
225 | $aliases = array_merge($aliases, |
||
226 | $this->prepareAliases($package, 'psr-0', true), |
||
227 | $this->prepareAliases($package, 'psr-4', true) |
||
228 | ); |
||
229 | } |
||
230 | |||
231 | return $aliases; |
||
232 | } |
||
233 | |||
234 | /** |
||
235 | * Prepare aliases. |
||
236 | * @param PackageInterface $package |
||
237 | * @param string 'psr-0' or 'psr-4' |
||
238 | * @return array |
||
239 | */ |
||
240 | protected function prepareAliases(PackageInterface $package, $psr, $dev = false) |
||
241 | { |
||
242 | $autoload = $dev ? $package->getDevAutoload() : $package->getAutoload(); |
||
243 | if (empty($autoload[$psr])) { |
||
244 | return []; |
||
245 | } |
||
246 | |||
247 | $aliases = []; |
||
248 | foreach ($autoload[$psr] as $name => $path) { |
||
249 | if (is_array($path)) { |
||
250 | // ignore psr-4 autoload specifications with multiple search paths |
||
251 | // we can not convert them into aliases as they are ambiguous |
||
252 | continue; |
||
253 | } |
||
254 | $name = str_replace('\\', '/', trim($name, '\\')); |
||
255 | $path = $this->preparePath($package, $path); |
||
256 | if ('psr-0' === $psr) { |
||
257 | $path .= '/' . $name; |
||
258 | } |
||
259 | $aliases["@$name"] = $path; |
||
260 | } |
||
261 | |||
262 | return $aliases; |
||
263 | } |
||
264 | |||
265 | /** |
||
266 | * Builds path inside of a package. |
||
267 | * @param PackageInterface $package |
||
268 | * @param mixed $path can be absolute or relative |
||
269 | * @return string absolute paths will stay untouched |
||
270 | */ |
||
271 | public function preparePath(PackageInterface $package, $path) |
||
272 | { |
||
273 | if (strncmp($path, '$', 1) === 0) { |
||
274 | return $path; |
||
275 | } |
||
276 | |||
277 | $skippable = strncmp($path, '?', 1) === 0 ? '?' : ''; |
||
278 | if ($skippable) { |
||
279 | $path = substr($path, 1); |
||
280 | } |
||
281 | |||
282 | if (!$this->getFilesystem()->isAbsolutePath($path)) { |
||
283 | $prefix = $package instanceof RootPackageInterface |
||
284 | ? $this->getBaseDir() |
||
285 | : $this->getVendorDir() . '/' . $package->getPrettyName(); |
||
286 | $path = $prefix . '/' . $path; |
||
287 | } |
||
288 | |||
289 | return $skippable . $this->getFilesystem()->normalizePath($path); |
||
290 | } |
||
291 | |||
292 | /** |
||
293 | * Sets [[packages]]. |
||
294 | * @param PackageInterface[] $packages |
||
295 | */ |
||
296 | 2 | public function setPackages(array $packages) |
|
300 | |||
301 | /** |
||
302 | * Gets [[packages]]. |
||
303 | * @return \Composer\Package\PackageInterface[] |
||
304 | */ |
||
305 | 1 | public function getPackages() |
|
306 | { |
||
307 | 1 | if ($this->packages === null) { |
|
308 | $this->packages = $this->findPackages(); |
||
313 | |||
314 | /** |
||
315 | * Plain list of all project dependencies (including nested) as provided by composer. |
||
316 | * The list is unordered (chaotic, can be different after every update). |
||
317 | */ |
||
318 | protected $plainList = []; |
||
319 | |||
320 | /** |
||
321 | * Ordered list of package in form: package => depth |
||
322 | * For order description @see findPackages. |
||
323 | */ |
||
324 | protected $orderedList = []; |
||
325 | |||
326 | /** |
||
327 | * Returns ordered list of packages: |
||
328 | * - listed earlier in the composer.json will get earlier in the list |
||
329 | * - childs before parents. |
||
330 | * @return \Composer\Package\PackageInterface[] |
||
331 | */ |
||
332 | public function findPackages() |
||
349 | |||
350 | /** |
||
351 | * Iterates through package dependencies. |
||
352 | * @param PackageInterface $package to iterate |
||
353 | * @param bool $includingDev process development dependencies, defaults to not process |
||
354 | */ |
||
355 | protected function iteratePackage(PackageInterface $package, $includingDev = false) |
||
381 | |||
382 | /** |
||
383 | * Iterates dependencies of the given package. |
||
384 | * @param PackageInterface $package |
||
385 | * @param bool $dev which dependencies to iterate: true - dev, default - general |
||
386 | */ |
||
387 | protected function iterateDependencies(PackageInterface $package, $dev = false) |
||
403 | |||
404 | protected function showDepsTree() |
||
419 | |||
420 | protected $colors = ['red', 'green', 'yellow', 'cyan', 'magenta', 'blue']; |
||
421 | |||
422 | /** |
||
423 | * Get absolute path to package base dir. |
||
424 | * @return string |
||
425 | */ |
||
426 | public function getBaseDir() |
||
434 | |||
435 | /** |
||
436 | * Get absolute path to composer vendor dir. |
||
437 | * @return string |
||
438 | */ |
||
439 | public function getVendorDir() |
||
448 | |||
449 | /** |
||
450 | * Getter for filesystem utility. |
||
451 | * @return Filesystem |
||
452 | */ |
||
453 | public function getFilesystem() |
||
461 | } |
||
462 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.