hiqdev / chkipper

src/lib/parsers/AbstractParser.php

<?php
/**
 * Changelog keeper
 *
 * @link      https://github.com/hiqdev/chkipper
 * @package   chkipper
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\chkipper\lib\parsers;

use hiqdev\chkipper\lib\Builder;

/**
 * Abstract history parser.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
abstract class AbstractParser extends Builder
{
    public function parsePath($path)
    {
        $lines = is_file($path) ? file($path) : [];

        return $this->parseLines($lines);

It seems like $lines can also be of type false; however, parameter $lines of hiqdev\chkipper\lib\parsers\AbstractParser::parseLines() does only seem to accept array, maybe add an additional type check?

    }

    abstract public function parseLines(array $lines);
}