hiqdev\chkipper\lib\changelog\NotesRenderer::render()

Complexity

Conditions	3
Paths	2

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

0

<?php
    public function render(History $history)
    {
        $this->setHistory($history);

        $links = $history->getLinks();
        $hrefs = [];
        $result = $this->renderObjects('renderNote', $history->getFirstTag()->getNotes());

        $result = preg_replace_callback('/\[(\S*?)\]/', function ($matches) use ($links, &$hrefs) {
            if (isset($links[$matches[1]])) {
                $hrefs[$matches[1]] = $links[$matches[1]];
            }

            return $matches[0];
        }, $result);

        if ($hrefs) {

The expression $hrefs of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $result .= PHP_EOL . $this->renderLinks($hrefs);
        }

        return $result;
    }
}