Completed
Push — master ( 7b4929...cefe8d )
by Andrii
01:50
created

Commit   A

Complexity

Total Complexity 25

Size/Duplication

Total Lines 123
Duplicated Lines 6.5 %

Coupling/Cohesion

Components 1
Dependencies 0

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 25
c 0
b 0
f 0
lcom 1
cbo 0
dl 8
loc 123
ccs 0
cts 87
cp 0
rs 10

16 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 6 1
A set() 0 6 1
A setHash() 0 4 1
A getHash() 0 4 1
A setLabel() 0 12 4
A getLabel() 0 6 4
A addComment() 0 4 1
A addComments() 0 6 2
A setComments() 0 5 1
A getComments() 0 4 1
A setDate() 8 9 2
A getDate() 0 4 2
A setSubject() 0 6 1
A getSubject() 0 4 1
A setAuthor() 0 6 1
A getAuthor() 0 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Changelog keeper
4
 *
5
 * @link      https://github.com/hiqdev/chkipper
6
 * @package   chkipper
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hiqdev\chkipper\history;
12
13
/**
14
 * Commit class.
15
 *
16
 * @property string $hash
17
 * @property string $label
18
 * @property array  $comments: comment => comment
19
 * @property string $date
20
 * @property string $author
21
 * @property string $hash
22
 *
23
 * @author Andrii Vasyliev <[email protected]>
24
 */
25
class Commit
26
{
27
    /**
28
     * @var string 7 characters commit hash
29
     */
30
    protected $_hash;
31
32
    /**
33
     * @var string string representation of commit
34
     */
35
    protected $_label;
36
    protected $_comments = [];
37
38
    protected $_date;
39
    protected $_author;
40
    protected $_subject;
41
42
    public function __construct($hash, $label = null, array $comments = [])
43
    {
44
        $this->setHash($hash);
45
        $this->setLabel($label);
46
        $this->setComments($comments);
47
    }
48
49
    public function set(Commit $commit)
50
    {
51
        $this->setHash($commit->hashHash());
0 ignored issues
show
Bug introduced by
The method hashHash() does not seem to exist on object<hiqdev\chkipper\history\Commit>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
52
        $this->setLabel($commit->getLabel());
53
        $this->setComments($commit->getComments());
54
    }
55
56
    public function setHash($hash)
57
    {
58
        $this->_hash = $hash;
59
    }
60
61
    public function getHash()
62
    {
63
        return $this->_hash;
64
    }
65
66
    public function setLabel($label)
67
    {
68
        if ($label) {
69
            $this->_label = $label;
70
            if (preg_match('/^(\d{4}-\d{2}-\d{2})\s*(.*?)\s*\[(\S*?)\]$/', $label, $m) ||
71
                preg_match('/^(\d{4}-\d{2}-\d{2})\s*(.*?)\s*\((\S*?)\)$/', $label, $m)) {
72
                $this->setDate($m[1]);
73
                $this->setSubject($m[2]);
74
                $this->setAuthor($m[3]);
75
            }
76
        }
77
    }
78
79
    public function getLabel()
80
    {
81
        return $this->_subject || $this->_date || $this->_author
82
            ? $this->getDate() . ' ' . $this->getSubject() . ' [' . $this->getAuthor() . ']'
83
            : $this->_label;
84
    }
85
86
    public function addComment($comment)
87
    {
88
        $this->_comments[$comment] = $comment;
89
    }
90
91
    public function addComments(array $comments)
92
    {
93
        foreach ($comments as $comment) {
94
            $this->addComment($comment);
95
        }
96
    }
97
98
    public function setComments($comments)
99
    {
100
        $this->_comments = [];
101
        $this->addComments($comments);
102
    }
103
104
    public function getComments()
105
    {
106
        return $this->_comments;
107
    }
108
109 View Code Duplication
    public function setDate($value)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
110
    {
111
        $timestamp = strtotime($value);
112
        if ($timestamp !== false) {
113
            $this->_date = $timestamp;
114
        }
115
116
        return $this;
117
    }
118
119
    public function getDate()
120
    {
121
        return $this->_date ? date('Y-m-d', $this->_date) : null;
122
    }
123
124
    public function setSubject($value)
125
    {
126
        $this->_subject = $value;
127
128
        return $this;
129
    }
130
131
    public function getSubject()
132
    {
133
        return $this->_subject;
134
    }
135
136
    public function setAuthor($value)
137
    {
138
        $this->_author = $value;
139
140
        return $this;
141
    }
142
143
    public function getAuthor()
144
    {
145
        return $this->_author;
146
    }
147
}
148