AbstractRenderer::skipCommit() - Code Metrics - Inspection of "added links generation" - hiqdev/chkipper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 874432...8867ab )

by Andrii

created 2016-06-20 21:06 UTC

AbstractRenderer::skipCommit() B

↳ Parent: AbstractRenderer

Complexity

Conditions	4
Paths	4

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	25
ccs	0
cts	11
cp	0
rs	8.5806
cc	4
eloc	15
nc	4
nop	1
crap	20

<?php

/*
 * Changelog keeper
 *
 * @link      https://github.com/hiqdev/chkipper
 * @package   chkipper
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\chkipper\history;

/**
 * Abstract history renderer.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
abstract class AbstractRenderer
{
    public function setHistory($value)
    {
        $this->_history = $value;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->prepareLinks();
    }

    public function getHistory()
    {
        return $this->_history;
    }

    /**
     * Renders history to string.
     * @param History $history
     * @return text
     */
    abstract public function render(History $history);

    public static function skipCommit(Commit $commit)
    {
        $comment = $commit['comment'];

        static $equals = [
            ''      => 1,
            'minor' => 1,
        ];
        if ($equals[$comment]) {
            return true;
        }

        static $starts = [
            'version bump',
            'bumped version',
            "merge branch 'master'",
        ];
        foreach ($starts as $start) {
            if (strtolower(substr($comment, 0, strlen($start))) === $start) {
                return true;
            }
        }

        return false;
    }

    public function prepareLinks()
    {
        $history = $this->getHistory();
        foreach ($history->getHashes() as $hash) {
            if (!$history->hasLink($hash)) {
                $history->addLink($hash, $this->generateHashHref($hash));
            }
        }
    }

    public function generateHashHref($hash)
    {
        return 'https://github.com/hiqdev/chkipper/commit/' . $hash;
    }
}


1		<?php
2
3		/*
4		* Changelog keeper
5		*
6		* @link https://github.com/hiqdev/chkipper
7		* @package chkipper
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hiqdev\chkipper\history;
13
14		/**
15		* Abstract history renderer.
16		*
17		* @author Andrii Vasyliev <[email protected]>
18		*/
19		abstract class AbstractRenderer
20		{
21	2	public function setHistory($value)
22		{
23	2	$this->_history = $value;
		0 ignored issues – show Bug introduced 2016-06-17 13:44 UTC by Report Bug Copy Issue Report The property `_history` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24	2	$this->prepareLinks();
25	2	}
26
27	2	public function getHistory()
28		{
29	2	return $this->_history;
30		}
31
32		/**
33		* Renders history to string.
34		* @param History $history
35		* @return text
36		*/
37		abstract public function render(History $history);
38
39		public static function skipCommit(Commit $commit)
40		{
41		$comment = $commit['comment'];
42
43		static $equals = [
44		'' => 1,
45		'minor' => 1,
46		];
47		if ($equals[$comment]) {
48		return true;
49		}
50
51		static $starts = [
52		'version bump',
53		'bumped version',
54		"merge branch 'master'",
55		];
56		foreach ($starts as $start) {
57		if (strtolower(substr($comment, 0, strlen($start))) === $start) {
58		return true;
59		}
60		}
61
62		return false;
63		}
64
65	2	public function prepareLinks()
66		{
67	2	$history = $this->getHistory();
68	2	foreach ($history->getHashes() as $hash) {
69	2	if (!$history->hasLink($hash)) {
70	1	$history->addLink($hash, $this->generateHashHref($hash));
71	1	}
72	2	}
73	2	}
74
75	1	public function generateHashHref($hash)
76		{
77	1	return 'https://github.com/hiqdev/chkipper/commit/' . $hash;
78		}
79		}
80

hiqdev / chkipper

Push — master ( 874432...8867ab )

AbstractRenderer::skipCommit() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like