hiqdev\chkipper\history\GitLogParser

Complexity

Total Complexity

15

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

59.38%

Importance

Changes	3
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	mergeTo()	0	5	1
A	mergeGitLog()	0	9	2
A	parseGitLog()	0	6	1
A	matchNote()	0	4	2
B	parseLines()	0	21	6
A	matchTag()	0	11	3

<?php

/*
 * Changelog keeper
 *
 * @link      https://github.com/hiqdev/chkipper
 * @package   chkipper
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\chkipper\history;

use UnexpectedValueException;

/**
 * Git log parser.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class GitLogParser extends AbstractParser
{
    public function mergeTo($history)
    {
        $this->setHistory($history);
        $this->mergeGitLog();
    }

    public function mergeGitLog()
    {
        $log = $this->fetchGitLog();

The method fetchGitLog() does not seem to exist on object<hiqdev\chkipper\history\GitLogParser>.

        var_dump($log);

var_dump($log); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        die();

The method mergeGitLog() contains an exit expression.

        foreach ($log as $hash => $data) {

foreach ($log as $hash => $data) { $this->getHistory()->addCommit($data['tag'], null, $data['commit'], true); } does not seem to be reachable.

            $this->getHistory()->addCommit($data['tag'], null, $data['commit'], true);

The method addCommit() does not exist on hiqdev\chkipper\history\History. Did you maybe mean addCommitLinks()?

        }
    }

    public function parseGitLog()
    {
        exec("git log --date=short --pretty='format:%h %ad %s [%ae] %d'", $logs);

        return $this->parseLines($logs);

It seems like $logs can also be of type null; however, hiqdev\chkipper\history\GitLogParser::parseLines() does only seem to accept array, maybe add an additional type check?

    }

    public function parseLines(array $lines)
    {
        $this->getHistory()->initTags();

        foreach ($lines as $line) {
            if (!preg_match('/^(\w+) (([0-9-]+) (.*?) \[.*?\]) *\(?(.*?)\)?$/', $line, $m)) {
                throw new UnexpectedValueException('failed parse git line');
            }
            $tag  = $this->matchTag($m[5]);
            $note = $this->matchNote($m[4]);
            if ($tag) {

The expression $tag of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                $this->addTag($tag, $m[3]);
            }
            if (false && $note) { /// disabled adding notes
                $this->addNote($note);
            }
            $this->addCommit($m[1], $m[2]);
        }

        return $this->getHistory();
    }

    /**
     * Finds first tag in given refs string.
     * @param string $str 
     * @return string
     */
    public function matchTag($str)
    {
        $refs = explode(', ', $str);
        foreach ($refs as $ref) {
            if (preg_match('/^tag: (.*)$/', $ref, $m)) {
                return $m[1];
            }
        }

        return null;
    }

    public function matchNote($str)
    {
        return strpos($str, ' ') ? $str : null;
    }
}