PrettifyUserLinks::run() - Code Metrics - hiqdev/chkipper - Measure and Improve Code Quality continuously with Scrutinizer

PrettifyUserLinks::run() B
last analyzed 2020-03-09 19:18 UTC

↳ Parent: PrettifyUserLinks

Complexity

Conditions	10
Paths	24

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	18.7765

Importance

Changes

Metric	Value
cc	10
eloc	15
nc	24
nop	1
dl	0
loc	20
ccs	10
cts	18
cp	0.5556
crap	18.7765
rs	7.6666
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * Changelog keeper
 *
 * @link      https://github.com/hiqdev/chkipper
 * @package   chkipper
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\chkipper\lib\modifiers;

use hiqdev\chkipper\lib\History;

/**
 * Modifier that prepares better links to users (committers) when possible.
 *
 * Git provides emails of commiters.
 * If you provide link to committer's personal page this modifier will spread
 * it all over the history.
 *
 * E.g. git provides my email as [email protected] for all my commits.
 * So my commits will look like this in history:
 * ```
 * - [0000000] 2017-01-01 commit comment [[email protected]]
 * ```
 * I want my commits to link to my github page: https://github.com/hiqsol
 * So I add these lines in the links part of the history (at the end of file):
 * ```
 * [@hiqsol]: https://github.com/hiqsol
 * [[email protected]]: https://github.com/hiqsol
 * ```
 * This modifier will change my commits to look like this:
 * ```
 * - [0000000] 2017-01-01 commit comment [@hiqsol]
 * ```
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class PrettifyUserLinks extends AbstractModifier
{
    /**
     * {@inheritdoc}
     */
    public function run(History $history)
    {
        $users = [];
        $subs = [];
        foreach ($history->getLinks() as $link => $href) {
            if (is_string($link) && $link[0] === '@') {
                $users[$href] = $link;
            } elseif (isset($users[$href])) {
                $subs[$link] = $users[$href];
            }
        }
        if (!$subs) {

            return;
        }
        foreach ($history->getTags() as $tag) {
            foreach ($tag->getNotes() as $note) {
                foreach ($note->getCommits() as $commit) {
                    $author = $commit->getAuthor();
                    if (isset($subs[$author])) {
                        $commit->setAuthor($subs[$author]);
                    }
                }
            }
        }
    }
}


1		<?php
2		/**
3		* Changelog keeper
4		*
5		* @link https://github.com/hiqdev/chkipper
6		* @package chkipper
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\chkipper\lib\modifiers;
12
13		use hiqdev\chkipper\lib\History;
14
15		/**
16		* Modifier that prepares better links to users (committers) when possible.
17		*
18		* Git provides emails of commiters.
19		* If you provide link to committer's personal page this modifier will spread
20		* it all over the history.
21		*
22		* E.g. git provides my email as [email protected] for all my commits.
23		* So my commits will look like this in history:
24		* ```
25		* - [0000000] 2017-01-01 commit comment [[email protected]]
26		* ```
27		* I want my commits to link to my github page: https://github.com/hiqsol
28		* So I add these lines in the links part of the history (at the end of file):
29		* ```
30		* [@hiqsol]: https://github.com/hiqsol
31		* [[email protected]]: https://github.com/hiqsol
32		* ```
33		* This modifier will change my commits to look like this:
34		* ```
35		* - [0000000] 2017-01-01 commit comment [@hiqsol]
36		* ```
37		*
38		* @author Andrii Vasyliev <[email protected]>
39		*/
40		class PrettifyUserLinks extends AbstractModifier
41		{
42		/**
43		* {@inheritdoc}
44		*/
45	2	public function run(History $history)
46		{
47	2	$users = [];
48	2	$subs = [];
49	2	foreach ($history->getLinks() as $link => $href) {
50	2	if (is_string($link) && $link[0] === '@') {
51	1	$users[$href] = $link;
52	2	} elseif (isset($users[$href])) {
53		$subs[$link] = $users[$href];
54		}
55	2	}
56	2	if (!$subs) {
		0 ignored issues – show introduced 2020-03-09 19:18 UTC by Report Bug Copy Issue Report `$subs` is of type `array`, thus it always evaluated to `false`. Loading history...
57	2	return;
58		}
59		foreach ($history->getTags() as $tag) {
60		foreach ($tag->getNotes() as $note) {
61		foreach ($note->getCommits() as $commit) {
62		$author = $commit->getAuthor();
63		if (isset($subs[$author])) {
64		$commit->setAuthor($subs[$author]);
65		}
66		}
67		}
68		}
69		}
70		}
71

hiqdev / chkipper

PrettifyUserLinks::run() B last analyzed 2020-03-09 19:18 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

PrettifyUserLinks::run() B
last analyzed 2020-03-09 19:18 UTC