hiqdev\chkipper\lib\modifiers\AddTagLinks

Complexity

Total Complexity

9

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	1	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	9	5
A	generateTagHref()	0	17	4

<?php
/**
 * Changelog keeper
 *
 * @link      https://github.com/hiqdev/chkipper
 * @package   chkipper
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\chkipper\lib\modifiers;

use hiqdev\chkipper\lib\History;

/**
 * Modifier that adds links for tags.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class AddTagLinks extends AbstractModifier
{
    /**
     * {@inheritdoc}
     */
    public function run(History $history)
    {
        $prev = null;
        foreach ($history->getTags() as $tag) {
            $tag = $tag->getName();
            if ($prev && ($history->isLastTag($prev) || !$history->hasLink($prev))) {
                $history->addLink($prev, static::generateTagHref($history, $prev, $tag));

$prev of type void is incompatible with the type string expected by parameter $prev of hiqdev\chkipper\lib\modifiers\AddTagLinks::generateTagHref().

The method hiqdev\chkipper\lib\modifiers\AddTagLinks::generateTagHref() is not static, but was called statically.

            }
            $prev = $tag;
        }
    }

    /**
     * Generate href to a version tag.
     * @param History $history history object
     * @param string $prev previous tag
     * @param string $curr current tag
     * @return string
     */
    public function generateTagHref(History $history, $prev, $curr)
    {
        $project = $history->getProject();
        $rmsSite = $history->getConfig()->rmsSite;

Accessing rmsSite on the interface hiqdev\chkipper\lib\ConfigInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($history->isInitTag($curr)) {
            if ($history->isLastTag($prev)) {
                return "https://$rmsSite/$project/releases";
            }

            return "https://$rmsSite/$project/releases/tag/$prev";
        }
        if ($history->isLastTag($prev)) {
            $prev = 'HEAD';
        }

        return "https://$rmsSite/$project/compare/$curr...$prev";
    }
}