Issues in MethodDeleteAction.php (master) - Issues in master - hiqdev/billing-hiapi - Measure and Improve Code Quality continuously with Scrutinizer

Issues (92)

src/method/Delete/MethodDeleteAction.php (1 issue)

Showing only issues like (Show All)

Checks if the types of returned expressions are compatible with the hinted types.

Best Practice Bug Major

<?php

namespace hiqdev\billing\hiapi\method\Delete;

use hiqdev\billing\hiapi\method\Create\MethodCreateCommand;
use hiqdev\billing\hiapi\method\MethodRepository;
use hiqdev\php\billing\method\Method;

class MethodDeleteAction
{
    /**
     * @var MethodRepository
     */
    private $repo;

    public function __construct(MethodRepository $repo)
    {
        $this->repo = $repo;
    }

    public function __invoke(MethodCreateCommand $command): Method
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
}


1			<?php
2
3			namespace hiqdev\billing\hiapi\method\Delete;
4
5			use hiqdev\billing\hiapi\method\Create\MethodCreateCommand;
6			use hiqdev\billing\hiapi\method\MethodRepository;
7			use hiqdev\php\billing\method\Method;
8
9			class MethodDeleteAction
10			{
11			/**
12			* @var MethodRepository
13			*/
14			private $repo;
15
16			public function __construct(MethodRepository $repo)
17			{
18			$this->repo = $repo;
19			}
20
21			public function __invoke(MethodCreateCommand $command): Method
22			{
23			}
			0 ignored issues – show Bug Best Practice introduced 2020-04-03 07:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `hiqdev\php\billing\method\Method`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
24			}
25

hiqdev / billing-hiapi

Issues (92)

src/method/Delete/MethodDeleteAction.php (1 issue)

Showing only issues like (Show All)

Introduced By

Duplication Side-by-Side

Filter issues like