hiqdev\billing\hiapi\plan\PlanRepository::create()

Complexity

Conditions	3
Paths	2

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	PlanRepository::findByOrder()	0	4	1
A	PlanRepository::findByIds()	0	8	1

<?php
/**
 * API for Billing
 *
 * @link      https://github.com/hiqdev/billing-hiapi
 * @package   billing-hiapi
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\billing\hiapi\plan;

use hiqdev\yii\DataMapper\models\relations\Bucket;
use hiqdev\php\billing\plan\Plan;
use hiqdev\php\billing\plan\PlanFactory;
use hiqdev\php\billing\plan\PlanInterface;
use hiqdev\php\billing\price\PriceInterface;
use hiqdev\yii\DataMapper\components\ConnectionInterface;
use hiqdev\yii\DataMapper\components\EntityManagerInterface;
use hiqdev\yii\DataMapper\query\Specification;
use hiqdev\yii\DataMapper\repositories\BaseRepository;
use hiqdev\php\billing\action\ActionInterface;
use hiqdev\php\billing\customer\Customer;
use hiqdev\php\billing\order\OrderInterface;
use hiqdev\php\billing\plan\PlanFactoryInterface;
use hiqdev\php\billing\plan\PlanRepositoryInterface;
use Yii;

class PlanRepository extends BaseRepository implements PlanRepositoryInterface
{
    /** {@inheritdoc} */
    public $queryClass = PlanQuery::class;

    /**
     * @param ActionInterface $action
     * @return PlanInterface
     */
    public function findByAction(ActionInterface $action)
    {
        $client_id = $action->getCustomer()->getId();
        $seller = $action->getCustomer()->getSeller()->getLogin();
        $type = $action->getTarget()->getType();

        $spec = Yii::createObject(Specification::class)
            ->with('prices')
            ->where([
                'type-name' => $type,
                'available_for' => [
                    'client_id' => $client_id,
                    'seller'    => $seller,
                ],
            ]);

        return $this->findOne($spec);

The expression $this->findOne($spec); of type object|false adds false to the return on line 54 which is incompatible with the return type declared by the interface hiqdev\php\billing\plan\PlanRepositoryInterface::findByAction of type hiqdev\php\billing\plan\PlanInterface. It seems like you forgot to handle an error condition.

    }

    /**
     * @param OrderInterface $order
     * @return Plan[]|PlanInterface[]
     */
    public function findByOrder(OrderInterface $order)
    {
        return array_map([$this, 'findByAction'], $order->getActions());
    }

    public function findByIds(array $ids)
    {
        $spec = Yii::createObject(Specification::class)
            ->with('prices')
            ->where(['id' => $ids]);

        return $this->findAll($spec);
    }

    protected function joinPrices(&$rows)
    {
        $bucket = Bucket::fromRows($rows, 'id');
        $spec = (new Specification())->where(['plan-id' => $bucket->getKeys()]);
        $prices = $this->getRepository(PriceInterface::class)->queryAll($spec);
        $bucket->fill($prices, 'plan.id', 'id');
        $bucket->pour($rows, 'prices');
    }

}