PriceHydrator::hydrate() - Code Metrics - Inspection of "added formula hydration" - hiqdev/billing-hiapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53418e...80ac75 )

by Andrii

created 2018-06-04 08:25 UTC

PriceHydrator::hydrate() D

↳ Parent: PriceHydrator

Complexity

Conditions	11
Paths	192

Size

Total Lines	28
Code Lines	18

Duplication

Lines	3
Ratio	10.71 %

Code Coverage

Tests	17
CRAP Score	11.0207

Importance

Changes

Metric	Value
dl	3
loc	28
ccs	17
cts	18
cp	0.9444
rs	4.9629
c	0
b	0
f	0
cc	11
eloc	18
nc	192
nop	2
crap	11.0207

How to fix Complexity

<?php
/**
 * API for Billing
 *
 * @link      https://github.com/hiqdev/billing-hiapi
 * @package   billing-hiapi
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\billing\hiapi\price;

use hiqdev\billing\hiapi\models\Plan;
use hiqdev\php\billing\formula\FormulaInterface;
use hiqdev\php\billing\price\PriceFactoryInterface;
use hiqdev\php\billing\target\Target;
use hiqdev\php\billing\type\Type;
use hiqdev\php\units\Quantity;
use hiqdev\php\units\Unit;
use hiqdev\yii\DataMapper\hydrator\GeneratedHydrator;
use Money\Currency;
use Money\Money;
use yii\helpers\Json;
use Zend\Hydrator\HydratorInterface;

/**
 * Class PriceHydrator.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class PriceHydrator extends GeneratedHydrator
{
    /**
     * @var PriceFactoryInterface|PriceFactory
     */
    protected $priceFactory;

    public function __construct(
        HydratorInterface $hydrator,
        PriceFactoryInterface $priceFactory
    ) {
        parent::__construct($hydrator);
        $this->priceFactory = $priceFactory;
    }

    /**
     * {@inheritdoc}
     * @param object|Plan $object
     */
    public function hydrate(array $row, $object)
    {
        $row['target'] = $this->hydrator->hydrate($row['target'], Target::class);
        $row['type'] = $this->hydrator->hydrate($row['type'], Type::class);
        if (isset($row['prepaid']['unit'])) {
            $row['unit'] = Unit::create($row['prepaid']['unit']);
        }
        if (isset($row['unit']) && isset($row['prepaid']['quantity'])) {
            $row['prepaid'] = Quantity::create($row['unit'], $row['prepaid']['quantity']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        if (isset($row['price']['currency'])) {
            $row['currency'] = new Currency(strtoupper($row['price']['currency']));
        }
        if (isset($row['currency']) && isset($row['price']['amount'])) {
            $row['price'] = new Money($row['price']['amount'], $row['currency']);
        }
        if (isset($row['data'])) {

            $data = is_array($row['data']) ? $row['data'] : Json::decode($row['data']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        if (isset($data['formula'])) {
            $row['formula'] = $this->hydrator->hydrate([$data['formula']], FormulaInterface::class);
        }

        $row['sums'] = empty($data['sums']) ? [] : $data['sums'];
        $row['subprices'] = $data['subprices'] ?? null;

        return parent::hydrate($row, $object);
    }

    /**
     * {@inheritdoc}
     * @param object|Plan $object
     */
    public function extract($object)

    {
        $result = array_filter([
            'id'            => $object->getId(),
            'name'          => $object->getName(),
            'parent_id'     => $object->parent->getid(),
            'seller_id'     => $object->seller->getid(),
        ]);

        return $result;
    }

    /**
     * @param string $className
     * @param array $data
     * @throws \ReflectionException
     * @return object
     */
    public function createEmptyInstance(string $className, array $data = [])
    {
        if (isset($data['data']) && !is_array($data['data'])) {

            $additionalData = Json::decode($data['data']);
        }

        $className = $this->priceFactory->findClassForTypes([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $additionalData['class'] ?? null,
            $data['type']['name'],
        ]);

        return parent::createEmptyInstance($className, $data);
    }
}


Push — master ( 53418e...80ac75 )

PriceHydrator::hydrate() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Available Fixes

1			<?php
2			/**
3			* API for Billing
4			*
5			* @link https://github.com/hiqdev/billing-hiapi
6			* @package billing-hiapi
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\billing\hiapi\price;
12
13			use hiqdev\billing\hiapi\models\Plan;
14			use hiqdev\php\billing\formula\FormulaInterface;
15			use hiqdev\php\billing\price\PriceFactoryInterface;
16			use hiqdev\php\billing\target\Target;
17			use hiqdev\php\billing\type\Type;
18			use hiqdev\php\units\Quantity;
19			use hiqdev\php\units\Unit;
20			use hiqdev\yii\DataMapper\hydrator\GeneratedHydrator;
21			use Money\Currency;
22			use Money\Money;
23			use yii\helpers\Json;
24			use Zend\Hydrator\HydratorInterface;
25
26			/**
27			* Class PriceHydrator.
28			*
29			* @author Andrii Vasyliev <[email protected]>
30			*/
31			class PriceHydrator extends GeneratedHydrator
32			{
33			/**
34			* @var PriceFactoryInterface\|PriceFactory
35			*/
36			protected $priceFactory;
37
38	3		public function __construct(
39			HydratorInterface $hydrator,
40			PriceFactoryInterface $priceFactory
41			) {
42	3		parent::__construct($hydrator);
43	3		$this->priceFactory = $priceFactory;
44	3		}
45
46			/**
47			* {@inheritdoc}
48			* @param object\|Plan $object
49			*/
50	4		public function hydrate(array $row, $object)
51			{
52	4		$row['target'] = $this->hydrator->hydrate($row['target'], Target::class);
53	4		$row['type'] = $this->hydrator->hydrate($row['type'], Type::class);
54	4		if (isset($row['prepaid']['unit'])) {
55	4		$row['unit'] = Unit::create($row['prepaid']['unit']);
56			}
57	4		if (isset($row['unit']) && isset($row['prepaid']['quantity'])) {
58	2		$row['prepaid'] = Quantity::create($row['unit'], $row['prepaid']['quantity']);
			0 ignored issues – show Documentation introduced 2018-05-29 16:12 UTC by Report Bug Copy Issue Report `$row['unit']` is of type `object`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59			}
60	4		if (isset($row['price']['currency'])) {
61	4		$row['currency'] = new Currency(strtoupper($row['price']['currency']));
62			}
63	4		if (isset($row['currency']) && isset($row['price']['amount'])) {
64	2		$row['price'] = new Money($row['price']['amount'], $row['currency']);
65			}
66	4	View Code Duplication	if (isset($row['data'])) {
			0 ignored issues – show Duplication introduced 2018-06-04 08:34 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67	2		$data = is_array($row['data']) ? $row['data'] : Json::decode($row['data']);
			0 ignored issues – show Documentation introduced 2018-06-04 08:34 UTC by Report Bug Copy Issue Report `$row['data']` is of type `object`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68			}
69	4		if (isset($data['formula'])) {
70			$row['formula'] = $this->hydrator->hydrate([$data['formula']], FormulaInterface::class);
71			}
72
73	4		$row['sums'] = empty($data['sums']) ? [] : $data['sums'];
74	4		$row['subprices'] = $data['subprices'] ?? null;
75
76	4		return parent::hydrate($row, $object);
77			}
78
79			/**
80			* {@inheritdoc}
81			* @param object\|Plan $object
82			*/
83		View Code Duplication	public function extract($object)
			0 ignored issues – show Duplication introduced 2018-05-04 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84			{
85			$result = array_filter([
86			'id' => $object->getId(),
87			'name' => $object->getName(),
88			'parent_id' => $object->parent->getid(),
89			'seller_id' => $object->seller->getid(),
90			]);
91
92			return $result;
93			}
94
95			/**
96			* @param string $className
97			* @param array $data
98			* @throws \ReflectionException
99			* @return object
100			*/
101	2		public function createEmptyInstance(string $className, array $data = [])
102			{
103	2	View Code Duplication	if (isset($data['data']) && !is_array($data['data'])) {
			0 ignored issues – show Duplication introduced 2018-05-23 15:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104	1		$additionalData = Json::decode($data['data']);
105			}
106
107	2		$className = $this->priceFactory->findClassForTypes([
			0 ignored issues – show Bug introduced 2018-05-23 15:15 UTC by Report Bug Copy Issue Report The method `findClassForTypes` does only exist in `hiqdev\billing\hiapi\price\PriceFactory`, but not in `hiqdev\php\billing\price\PriceFactoryInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
108	2		$additionalData['class'] ?? null,
109	2		$data['type']['name'],
110			]);
111
112	2		return parent::createEmptyInstance($className, $data);
113			}
114			}
115

hiqdev / billing-hiapi

Push — master ( 53418e...80ac75 )

PriceHydrator::hydrate() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like