hiqdev\billing\hiapi\charge\Generalizer

Complexity

Total Complexity

8

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	generalizeTarget()	0	17	1
A	moreGeneral()	0	4	3
A	lessGeneral()	0	4	3
A	isMoreGeneral()	0	21	1

<?php

namespace hiqdev\billing\hiapi\charge;

use DateTimeImmutable;
use hiqdev\php\billing\bill\Bill;
use hiqdev\php\billing\bill\BillInterface;
use hiqdev\php\billing\charge\ChargeInterface;
use hiqdev\php\billing\target\TargetInterface;
use hiqdev\php\units\QuantityInterface;
use Money\Money;

/**
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class Generalizer extends \hiqdev\php\billing\charge\Generalizer
{
    public function generalizeTarget(ChargeInterface $charge)
    {
        return $this->moreGeneral($charge->getAction()->getTarget(), $charge->getPrice()->getTarget());

        /* Sorry, to be removed later, older variants

59% of this comment could be valid code. Did you maybe forget this after debugging?

         * 1:
            if (in_array($charge->getTarget()->getType(), ['certificate', 'domain'], TRUE)) {
                $priceTarget = $charge->getPrice()->getTarget();
                if ($priceTarget->getId()) {
                    return $priceTarget;
                }
            }
            return parent::generalizeTarget($charge);
         * 2:
            return $priceTarget->getId() ? $priceTarget : new Target($charge->getSale()->getPlan()->getId(), 'plan');
         */
    }

    public function moreGeneral(TargetInterface $first, TargetInterface $other)
    {
        return $this->isMoreGeneral($first, $other) || !$other->hasId() ? $first : $other;

The method hasId() does not seem to exist on object<hiqdev\php\billing\target\TargetInterface>.

    }

    public function lessGeneral(TargetInterface $first, TargetInterface $other)
    {
        return $this->isMoreGeneral($first, $other) || !$first->hasId() ? $other : $first;

The method hasId() does not seem to exist on object<hiqdev\php\billing\target\TargetInterface>.

    }

    public function isMoreGeneral(TargetInterface $first, TargetInterface $other)
    {
        $i = 0;
        $order = [
            'domain'        => ++$i,
            'zone'          => ++$i,
            'certificate'   => ++$i,
            'type'          => ++$i,
            'part'          => ++$i,
            'server'        => ++$i,
            'device'        =>   $i,
            'tariff'        => ++$i,
            'ref'           => ++$i,
            ''              => ++$i,
        ];

        $lhs = $order[(string)$first->getType()];
        $rhs = $order[(string)$other->getType()];

        return $lhs > $rhs;
    }

}