Issues in BillStateHydrator.php - All Issues - Inspection of "Merge grouping charges of grouping plan into a sin..." - hiqdev/billing-hiapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 104946...6683dc )

by Dmitry

created 2018-12-07 10:28 UTC

src/bill/BillStateHydrator.php (1 issue)

Labels

Severity

Major 1

<?php
/**
 * API for Billing
 *
 * @link      https://github.com/hiqdev/billing-hiapi
 * @package   billing-hiapi
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\billing\hiapi\bill;

use hiqdev\php\billing\bill\BillState;
use hiqdev\yii\DataMapper\hydrator\GeneratedHydrator;

/**
 * BillState Hydrator.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class BillStateHydrator extends GeneratedHydrator
{
    public function hydrate(array $data, $object)
    {
        return BillState::fromString($data['state'] ?? reset($data));
    }

    /**
     * {@inheritdoc}
     * @param BillState $object
     */
    public function extract($object)
    {
        return $object->getName();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2			/**
3			* API for Billing
4			*
5			* @link https://github.com/hiqdev/billing-hiapi
6			* @package billing-hiapi
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\billing\hiapi\bill;
12
13			use hiqdev\php\billing\bill\BillState;
14			use hiqdev\yii\DataMapper\hydrator\GeneratedHydrator;
15
16			/**
17			* BillState Hydrator.
18			*
19			* @author Andrii Vasyliev <[email protected]>
20			*/
21			class BillStateHydrator extends GeneratedHydrator
22			{
23			public function hydrate(array $data, $object)
24			{
25			return BillState::fromString($data['state'] ?? reset($data));
26			}
27
28			/**
29			* {@inheritdoc}
30			* @param BillState $object
31			*/
32			public function extract($object)
33			{
34			return $object->getName();
			0 ignored issues – show Bug Best Practice introduced 2018-06-18 19:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $object->getName()` returns the type `string` which is incompatible with the return type mandated by `Zend\Hydrator\ExtractionInterface::extract()` of `array`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
35			}
36			}
37

hiqdev / billing-hiapi

Push — master ( 104946...6683dc )

src/bill/BillStateHydrator.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like