Plan - Code Metrics - Inspection of "Continue" - hiqdev/billing-hiapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 796b11...f7c1ef )

by Dmitry

created 2017-06-02 07:15 UTC

Plan A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	39
ccs	0
cts	24
cp	0
rs	10

7 Methods

Rating	Name	Size	Complexity
A	tableName()	4	1
A	conversions()	6	1
A	getSeller()	4	1
A	getPrices()	4	1
A	getType()	4	1
A	getTarget()	4	1
A	getEntity()	4	1

<?php

namespace hiqdev\billing\hiapi\models;

use hiqdev\php\billing\Plan as Entity;
use yii\db\ActiveRecord;

class Plan extends ActiveRecord
{
    public static function tableName()
    {
        return 'tariff';
    }

    public static function conversions()
    {
        return [
            'id' => 'obj_id',
        ];
    }

    public function getSeller()
    {
        return $this->hasOne(Customer::class, ['obj_id' => 'client_id']);
    }

    public function getPrices()
    {
        return $this->hasMany(Price::class, ['tariff_id' => 'obj_id']);
    }

    public function getType()
    {
        return $this->hasOne(Type::class, ['obj_id' => 'type_id']);
    }

    public function getTarget()
    {
        return $this->hasOne(Target::class, ['obj_id' => 'object_id']);
    }

    public function getEntity()
    {
        return new Entity($this->obj_id, $this->name, $this->seller->getEntity());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace hiqdev\billing\hiapi\models;
4
5			use hiqdev\php\billing\Plan as Entity;
6			use yii\db\ActiveRecord;
7
8			class Plan extends ActiveRecord
9			{
10			public static function tableName()
11			{
12			return 'tariff';
13			}
14
15			public static function conversions()
16			{
17			return [
18			'id' => 'obj_id',
19			];
20			}
21
22			public function getSeller()
23			{
24			return $this->hasOne(Customer::class, ['obj_id' => 'client_id']);
25			}
26
27			public function getPrices()
28			{
29			return $this->hasMany(Price::class, ['tariff_id' => 'obj_id']);
30			}
31
32			public function getType()
33			{
34			return $this->hasOne(Type::class, ['obj_id' => 'type_id']);
35			}
36
37			public function getTarget()
38			{
39			return $this->hasOne(Target::class, ['obj_id' => 'object_id']);
40			}
41
42			public function getEntity()
43			{
44			return new Entity($this->obj_id, $this->name, $this->seller->getEntity());
			0 ignored issues – show Documentation introduced 2017-05-29 09:39 UTC by Report Bug Copy Issue Report The property `obj_id` does not exist on `object<hiqdev\billing\hiapi\models\Plan>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-05-29 09:39 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<hiqdev\billing\hiapi\models\Plan>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-05-29 09:39 UTC by Report Bug Copy Issue Report The property `seller` does not exist on `object<hiqdev\billing\hiapi\models\Plan>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45			}
46			}
47

hiqdev / billing-hiapi

Push — master ( 796b11...f7c1ef )

Plan A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like