hiqdev\billing\hiapi\tools\CleanForTests\Action

Complexity

Total Complexity

5

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	3	1
A	__construct()	0	3	1
A	checkRequiredInput()	0	5	3

<?php

namespace hiqdev\billing\hiapi\tools\CleanForTests;

use hiqdev\billing\hiapi\customer\CustomerRepository;
use hiapi\exceptions\domain\RequiredInputException;
use hiqdev\php\billing\customer\Customer;

class Action
{
    /**
     * @var CustomerRepository
     */
    private $repo;

    public function __construct(CustomerRepository $repo)
    {
        $this->repo = $repo;
    }

    public function __invoke(Command $command): Customer
    {
        $this->checkRequiredInput($command);

In this branch, the function will implicitly return null which is incompatible with the type-hinted return hiqdev\php\billing\customer\Customer. Consider adding a return statement or allowing null as return value.

    }

    protected function checkRequiredInput(Command $command)
    {
        if (empty($command->customer_id)) {
            if (empty($command->customer)) {

The property customer does not exist on hiqdev\billing\hiapi\tools\CleanForTests\Command. Since you implemented __get, consider adding a @property annotation.

                throw new RequiredInputException('customer or customer_id');
            }
        }
    }
}