hiqdev\billing\hiapi\sale\Close\ActionCalculateAction

Complexity

Total Complexity

5

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	checkRequiredInput()	0	7	3
A	__invoke()	0	3	1
A	__construct()	0	3	1

<?php

namespace hiqdev\billing\hiapi\sale\Close;

use hiqdev\billing\hiapi\action\ActionRepository;
use hiqdev\billing\hiapi\action\Calculate\ActionCalculateCommand;
use hiqdev\php\billing\action\Action;

class ActionCalculateAction
{
    /**
     * @var ActionRepository
     */
    private $repo;

    public function __construct(ActionRepository $repo)
    {
        $this->repo = $repo;
    }

    public function __invoke(ActionCalculateCommand $command): Action
    {
        $this->checkRequiredInput($command);

In this branch, the function will implicitly return null which is incompatible with the type-hinted return hiqdev\php\billing\action\Action. Consider adding a return statement or allowing null as return value.

//        $action = new Action();
//         $this->repo->calculate($action);

//        return $action;
    }

    protected function checkRequiredInput(ActionCalculateCommand $command): void
    {
        if (empty($command->customer)) {

The property customer does not exist on hiqdev\billing\hiapi\action\Calculate\ActionCalculateCommand. Since you implemented __get, consider adding a @property annotation.

            throw new RequiredInputException('customer');

The type hiqdev\billing\hiapi\sale\Close\RequiredInputException was not found. Maybe you did not declare it correctly or list all dependencies?

        }
        if (empty($command->target)) {

The property target does not exist on hiqdev\billing\hiapi\action\Calculate\ActionCalculateCommand. Since you implemented __get, consider adding a @property annotation.

            throw new RequiredInputException('target');
        }
    }
}