hiqdev /
billing-hiapi
| Conditions | 10 |
| Paths | 384 |
| Total Lines | 30 |
| Code Lines | 19 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 18 |
| CRAP Score | 10.1 |
| Changes | 6 | ||
| Bugs | 2 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 51 | 4 | public function hydrate(array $row, $object) |
|
| 52 | { |
||
| 53 | 4 | $row['target'] = $this->hydrator->hydrate($row['target'] ?? [], Target::class); |
|
|
Bug
introduced
by
|
|||
| 54 | 4 | $row['type'] = $this->hydrator->hydrate($row['type'], Type::class); |
|
| 55 | 4 | if (isset($row['prepaid']['unit'])) { |
|
| 56 | 4 | $row['unit'] = Unit::create($row['prepaid']['unit']); |
|
| 57 | } |
||
| 58 | 4 | if (isset($row['unit'], $row['prepaid']['quantity'])) { |
|
| 59 | 2 | $row['prepaid'] = Quantity::create($row['unit'], $row['prepaid']['quantity']); |
|
| 60 | } |
||
| 61 | 4 | if (isset($row['price']['currency'])) { |
|
| 62 | 4 | $row['currency'] = new Currency(strtoupper($row['price']['currency'])); |
|
| 63 | } |
||
| 64 | 4 | if (isset($row['currency'], $row['price']['amount'])) { |
|
| 65 | 2 | $row['price'] = new Money($row['price']['amount'], $row['currency']); |
|
| 66 | } |
||
| 67 | 4 | if (!empty($row['plan'])) { |
|
| 68 | $row['plan'] = $this->hydrator->create($row['plan'], Plan::class); |
||
| 69 | } |
||
| 70 | 4 | if (isset($row['data'])) { |
|
| 71 | 2 | $data = is_array($row['data']) ? $row['data'] : Json::decode($row['data']); |
|
| 72 | } |
||
| 73 | 4 | if (!empty($data['formula'])) { |
|
| 74 | $row['modifier'] = $this->hydrator->hydrate([$data['formula']], FormulaInterface::class); |
||
| 75 | } |
||
| 76 | |||
| 77 | 4 | $row['sums'] = empty($data['sums']) ? [] : $data['sums']; |
|
| 78 | 4 | $row['subprices'] = $data['subprices'] ?? null; |
|
| 79 | |||
| 80 | 4 | return parent::hydrate($row, $object); |
|
| 81 | } |
||
| 117 |
Loading history...
