AvailableForField::buildCondition() - Code Metrics - hiqdev/billing-hiapi - Measure and Improve Code Quality continuously with Scrutinizer

AvailableForField::buildCondition() A
last analyzed 2020-04-24 14:13 UTC

↳ Parent: AvailableForField

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
eloc	8
c	2
b	1
f	1
dl	0
loc	21
ccs	0
cts	20
cp	0
rs	10
cc	2
nc	2
nop	2
crap	6

<?php
/**
 * API for Billing
 *
 * @link      https://github.com/hiqdev/billing-hiapi
 * @package   billing-hiapi
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\billing\hiapi\plan;

use hiqdev\yii\DataMapper\query\FieldInterface;
use yii\db\Expression;

class AvailableForField implements FieldInterface
{
    public $name = 'available_for';

    public function canBeSelected()
    {
        return false;
    }

    public function isApplicable($key)
    {
        return strcasecmp($this->name, $key) === 0;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    public function buildCondition($key, $value)
    {
        $params = [];
        if ($value['client_id']) {
            $params[':available_for_client_id'] = $value['client_id'];
            $ids_sql = '
                SELECT      tariff_id
                FROM        client2tariff
                WHERE       client_id=:available_for_client_id
            ';
        } else {
            $params[':available_for_seller'] = $value['seller'];
            $ids_sql = "
                SELECT      dst_id
                FROM        tie
                WHERE       src_id=client_id(:available_for_seller)
                        AND tag_id=type_id('tariff')
            ";
        }

        return new Expression("zt.obj_id IN ($ids_sql)", $params);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2			/**
3			* API for Billing
4			*
5			* @link https://github.com/hiqdev/billing-hiapi
6			* @package billing-hiapi
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\billing\hiapi\plan;
12
13			use hiqdev\yii\DataMapper\query\FieldInterface;
14			use yii\db\Expression;
15
16			class AvailableForField implements FieldInterface
17			{
18			public $name = 'available_for';
19
20			public function canBeSelected()
21			{
22			return false;
23			}
24
25			public function isApplicable($key)
26			{
27			return strcasecmp($this->name, $key) === 0;
28			}
29
30			/**
31			* @return string
32			*/
33			public function getName()
34			{
35			return $this->name;
36			}
37
38			public function buildCondition($key, $value)
39			{
40			$params = [];
41			if ($value['client_id']) {
42			$params[':available_for_client_id'] = $value['client_id'];
43			$ids_sql = '
44			SELECT tariff_id
45			FROM client2tariff
46			WHERE client_id=:available_for_client_id
47			';
48			} else {
49			$params[':available_for_seller'] = $value['seller'];
50			$ids_sql = "
51			SELECT dst_id
52			FROM tie
53			WHERE src_id=client_id(:available_for_seller)
54			AND tag_id=type_id('tariff')
55			";
56			}
57
58			return new Expression("zt.obj_id IN ($ids_sql)", $params);
			0 ignored issues – show Bug Best Practice introduced 2018-11-09 13:08 UTC by Report Bug Copy Issue Report The expression `return new yii\db\Expres....$ids_sql.')', $params)` returns the type `yii\db\Expression` which is incompatible with the return type mandated by `hiqdev\yii\DataMapper\qu...rface::buildCondition()` of `array\|yii\db\conditions\ConditionInterface`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
59			}
60			}
61

hiqdev / billing-hiapi

AvailableForField::buildCondition() A last analyzed 2020-04-24 14:13 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AvailableForField::buildCondition() A
last analyzed 2020-04-24 14:13 UTC