CustomerLoader::findCustomer() - Code Metrics - hiqdev/billing-hiapi - Measure and Improve Code Quality continuously with Scrutinizer

CustomerLoader::findCustomer() A
last analyzed 2020-04-24 14:13 UTC

↳ Parent: CustomerLoader

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	12
rs	10
cc	3
nc	3
nop	1

<?php
/**
 * API for Billing
 *
 * @link      https://github.com/hiqdev/billing-hiapi
 * @package   billing-hiapi
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\billing\hiapi\customer;

use League\Tactician\Middleware;
use hiqdev\php\billing\customer\Customer;
use hiqdev\billing\hiapi\customer\CustomerRepository;
use yii\web\User;

class CustomerLoader implements Middleware
{
    private $repo;

    private $user;

    public function __construct(User $user, CustomerRepository $repo)
    {
        $this->user = $user;
        $this->repo = $repo;
    }

    public function execute($command, callable $next)
    {
        if (empty($command->customer)) {
            $command->customer = $this->findCustomer($command);
        }

        return $next($command);
    }

    private function findCustomer($command): Customer
    {
        if (empty($command->customer_id)) {
            return $this->getCurrentCustomer();
        }

        $res = $this->repo->findById($command->customer_id);
        if (empty($res)) {
            return $this->getCurrentCustomer();
        }

        return $res;
    }

    private function getCurrentCustomer(): Customer
    {
        return new Customer($this->user->id, $this->user->getIdentity()->username);

    }
}


1			<?php
2			/**
3			* API for Billing
4			*
5			* @link https://github.com/hiqdev/billing-hiapi
6			* @package billing-hiapi
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\billing\hiapi\customer;
12
13			use League\Tactician\Middleware;
14			use hiqdev\php\billing\customer\Customer;
15			use hiqdev\billing\hiapi\customer\CustomerRepository;
16			use yii\web\User;
17
18			class CustomerLoader implements Middleware
19			{
20			private $repo;
21
22			private $user;
23
24			public function __construct(User $user, CustomerRepository $repo)
25			{
26			$this->user = $user;
27			$this->repo = $repo;
28			}
29
30			public function execute($command, callable $next)
31			{
32			if (empty($command->customer)) {
33			$command->customer = $this->findCustomer($command);
34			}
35
36			return $next($command);
37			}
38
39			private function findCustomer($command): Customer
40			{
41			if (empty($command->customer_id)) {
42			return $this->getCurrentCustomer();
43			}
44
45			$res = $this->repo->findById($command->customer_id);
46			if (empty($res)) {
47			return $this->getCurrentCustomer();
48			}
49
50			return $res;
51			}
52
53			private function getCurrentCustomer(): Customer
54			{
55			return new Customer($this->user->id, $this->user->getIdentity()->username);
			0 ignored issues – show Bug introduced 2020-03-31 16:29 UTC by Report Bug Copy Issue Report Accessing `username` on the interface `yii\web\IdentityInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
56			}
57			}
58

hiqdev / billing-hiapi

CustomerLoader::findCustomer() A last analyzed 2020-04-24 14:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CustomerLoader::findCustomer() A
last analyzed 2020-04-24 14:13 UTC