hiqdev\billing\hiapi\type\TypeSemantics

Complexity

Total Complexity

10

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Test Coverage

Coverage

45%

Importance

Changes	4
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	createMonthlyType()	0	3	1
A	groupName()	0	8	2
A	isDiscount()	0	3	1
A	isDeposit()	0	3	1
A	isMonthly()	0	3	1
A	isHardware()	0	3	1
A	localName()	0	8	2
A	isOveruse()	0	3	1

<?php

namespace hiqdev\billing\hiapi\type;

use hiqdev\php\billing\type\Type;
use hiqdev\php\billing\type\TypeInterface;

final class TypeSemantics
{
    private const MONTHLY  = 'monthly';
    private const OVERUSE  = 'overuse';
    private const DISCOUNT = 'discount';
    private const DEPOSIT  = 'deposit';
    private const HARDWARE = 'hardware';

    /**
     * // TODO: Probably not the best place for this method
     *
     * @return TypeInterface
     */
    public function createMonthlyType(): TypeInterface
    {
        return new Type(null, self::MONTHLY . ',' . self::MONTHLY);
    }

    /**
     * @param TypeInterface $type
     * @return bool
     */
    public function isMonthly(TypeInterface $type): bool
    {
        return $this->groupName($type) === self::MONTHLY;
    }

    /**
     * @param TypeInterface $type
     * @return bool
     */
    public function isHardware(TypeInterface $type): bool
    {
        return $this->localName($type) === self::HARDWARE;
    }

    /**
     * @param TypeInterface $type
     * @return bool
     */
    public function isDiscount(TypeInterface $type): bool
    {
        return $this->groupName($type) === self::DISCOUNT;
    }

    /**
     * @param TypeInterface $type
     * @return bool
     */
    public function isOveruse(TypeInterface $type): bool
    {
        return $this->groupName($type) === self::OVERUSE;
    }

    /**
     * @param TypeInterface $type
     * @return bool
     */
    public function isDeposit(TypeInterface $type): bool
    {
        return $this->groupName($type) === self::DEPOSIT;
    }

    /**
     * @param TypeInterface $type
     * @return string
     */
    public function groupName(TypeInterface $type): string
    {
        $name = $type->getName();
        if (strpos($name, ',') !== false) {
            [$name,] = explode(',', $name, 2);
        }

        return $name;

The expression return $name could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    public function localName(TypeInterface $type): string
    {
        $name = $type->getName();
        if (strpos($name, ',') !== false) {
            [,$name] = explode(',', $name, 2);
        }

        return $name;

The expression return $name could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}