Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class PackageRepository |
||
10 | { |
||
11 | /** |
||
12 | * @var Connection |
||
13 | */ |
||
14 | protected $db; |
||
15 | |||
16 | /** |
||
17 | * PackageRepository constructor. |
||
18 | * @param Connection $db |
||
19 | */ |
||
20 | public function __construct(Connection $db) |
||
24 | |||
25 | /** |
||
26 | * @param AssetPackage $package |
||
27 | * @return int |
||
28 | */ |
||
29 | public function save(AssetPackage $package) |
||
37 | |||
38 | /** |
||
39 | * @param AssetPackage $package |
||
40 | * @return int |
||
41 | */ |
||
42 | View Code Duplication | public function insert(AssetPackage $package) { |
|
49 | |||
50 | /** |
||
51 | * @param AssetPackage $package |
||
52 | * @return int |
||
53 | */ |
||
54 | View Code Duplication | public function update(AssetPackage $package) |
|
63 | |||
64 | /** |
||
65 | * @param AssetPackage $package |
||
66 | * @return bool |
||
67 | */ |
||
68 | public function exists(AssetPackage $package) |
||
75 | |||
76 | /** |
||
77 | * @return \hiqdev\assetpackagist\models\AssetPackage[] |
||
78 | */ |
||
79 | public function getExpired() |
||
88 | |||
89 | /** |
||
90 | * @param array $rows |
||
91 | * @return AssetPackage[] |
||
92 | */ |
||
93 | public function hydrate($rows) |
||
102 | } |
||
103 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.