AssetPackage::getRelease() - Code Metrics - Inspection of "Implemented package update from the we application" - hiqdev/asset-packagist - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5d7641...f3f873 )

by Dmitry

created 2016-05-18 12:22 UTC

AssetPackage::getRelease() A

↳ Parent: AssetPackage

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
cc	2
eloc	2
nc	2
nop	1
crap	6

<?php

/*
 * Asset Packagist
 *
 * @link      https://github.com/hiqdev/asset-packagist
 * @package   asset-packagist
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\assetpackagist\models;

use Composer\Composer;
use Composer\Factory;
use Composer\IO\NullIO;
use Exception;
use Fxp\Composer\AssetPlugin\Repository\AssetVcsRepository;
use hiqdev\assetpackagist\registry\RegistryFactory;
use Yii;

class AssetPackage
{
    protected $_type;
    protected $_name;
    protected $_hash;
    protected $_releases = [];
    protected $_saved;

    /**
     * @var NullIO
     */
    protected $_io;
    /**
     * @var Composer
     */
    protected $_composer;
    /**
     * @var Storage
     */
    protected $_storage;
    /**
     * @var Composer
     */
    protected static $_commonComposer;

    public function __construct($type, $name)
    {
        if (!$this->checkType($type)) {
            throw new Exception('wrong type');
        }
        if (!$this->checkName($name)) {
            throw new Exception('wrong name');
        }
        $this->_type = $type;
        $this->_name = $name;
    }

    public function checkType($type)
    {
        return $type === 'bower' || $type === 'npm';
    }

    public function checkName($name)
    {
        return strlen($name) > 1;
    }

    public function getFullName()
    {
        return static::buildFullName($this->_type, $this->_name);
    }

    public static function buildFullName($type, $name)
    {
        return $type . '-asset/' . $name;
    }

    public static function splitFullName($full)
    {
        list($temp, $name) = explode('/', $full);
        list($type, $temp) = explode('-', $temp);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        return [$type, $name];
    }

    public function getType()
    {
        return $this->_type;
    }

    public function getName()
    {
        return $this->_name;
    }

    public function getHash()
    {
        return $this->_hash;
    }

    /**
     * @return Composer
     */
    public static function getCommonComposer()
    {
        if (static::$_commonComposer === null) {
            static::$_commonComposer = (new Factory)->createComposer(
                new NullIO(),
                Yii::getAlias('@composer/composer.json'),

                false,
                Yii::getAlias('@composer')
            );
        }

        return static::$_commonComposer;
    }

    public function setComposer($value)
    {
        $this->_composer = $value;
    }

    /**
     * @return Composer
     */
    public function getComposer()
    {
        if ($this->_composer === null) {
            $this->_composer = static::getCommonComposer();
        }

        return $this->_composer;
    }

    public function getIO()
    {
        if ($this->_io === null) {
            $this->_io = new NullIO();
        }

        return $this->_io;
    }

    /**
     * findOne.
     *
     * @param string $type
     * @param string $name
     * @return static|null
     */
    public static function findOne($type, $name)
    {
        $package = new static($type, $name);
        $package->load();

        return $package;
    }

    public function load()
    {
        $data = $this->getStorage()->readPackage($this);
        $this->_hash = $data['hash'];
        $this->_releases = $data['releases'];
    }

    public function update()
    {
        $registry = RegistryFactory::getRegistry($this->getType(), $this->getComposer()->getRepositoryManager());
        $repo = $registry->buildVcsRepository($this->getName());
        $this->_releases = $this->prepareReleases($repo);
        $this->_hash = $this->getStorage()->writePackage($this);
    }

    /**
     * @param AssetVcsRepository $repository
     * @return array
     */
    public function prepareReleases($repository)
    {
        $releases = [];
        foreach ($repository->getPackages() as $package) {
            $version = $package->getVersion();
            $release = [
                'uid' => $this->prepareUid($version),
                'name' => $this->getFullName(),
                'version' => $version,
            ];
            if ($package->getDistUrl()) {
                $release['dist'] = [
                    'type' => $package->getDistType(),
                    'url' => $package->getDistUrl(),
                    'reference' => $package->getDistReference(),
                ];
            }
            if ($package->getSourceUrl()) {
                $release['source'] = [
                    'type' => $package->getSourceType(),
                    'url' => $package->getSourceUrl(),
                    'reference' => $package->getSourceReference(),
                ];
            }
            if ($release['dist'] || $release['source']) {
                $releases[$version] = $release;
            }
        }

        return $releases;
    }

    public function prepareUid($version)
    {
        $known = $this->getSaved()->getRelease($version);

        return isset($known['uid']) ? $known['uid'] : $this->getStorage()->getNextID();
    }

    public function getReleases()
    {
        return $this->_releases;
    }

    public function getRelease($version)
    {
        return isset($this->_releases[$version]) ? $this->_releases[$version] : [];
    }

    public function getSaved()
    {
        if ($this->_saved === null) {
            $this->_saved = static::findOne($this->getType(), $this->getName());
        }

        return $this->_saved;
    }

    public function getStorage()
    {
        if ($this->_storage === null) {
            $this->_storage = Storage::getInstance();
        }

        return $this->_storage;
    }
}


1		<?php
2
3		/*
4		* Asset Packagist
5		*
6		* @link https://github.com/hiqdev/asset-packagist
7		* @package asset-packagist
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hiqdev\assetpackagist\models;
13
14		use Composer\Composer;
15		use Composer\Factory;
16		use Composer\IO\NullIO;
17		use Exception;
18		use Fxp\Composer\AssetPlugin\Repository\AssetVcsRepository;
19		use hiqdev\assetpackagist\registry\RegistryFactory;
20		use Yii;
21
22		class AssetPackage
23		{
24		protected $_type;
25		protected $_name;
26		protected $_hash;
27		protected $_releases = [];
28		protected $_saved;
29
30		/**
31		* @var NullIO
32		*/
33		protected $_io;
34		/**
35		* @var Composer
36		*/
37		protected $_composer;
38		/**
39		* @var Storage
40		*/
41		protected $_storage;
42		/**
43		* @var Composer
44		*/
45		protected static $_commonComposer;
46
47	1	public function __construct($type, $name)
48		{
49	1	if (!$this->checkType($type)) {
50		throw new Exception('wrong type');
51		}
52	1	if (!$this->checkName($name)) {
53		throw new Exception('wrong name');
54		}
55	1	$this->_type = $type;
56	1	$this->_name = $name;
57	1	}
58
59	1	public function checkType($type)
60		{
61	1	return $type === 'bower' \|\| $type === 'npm';
62		}
63
64	1	public function checkName($name)
65		{
66	1	return strlen($name) > 1;
67		}
68
69	1	public function getFullName()
70		{
71	1	return static::buildFullName($this->_type, $this->_name);
72		}
73
74	1	public static function buildFullName($type, $name)
75		{
76	1	return $type . '-asset/' . $name;
77		}
78
79		public static function splitFullName($full)
80		{
81		list($temp, $name) = explode('/', $full);
82		list($type, $temp) = explode('-', $temp);
		0 ignored issues – show Unused Code introduced 2016-05-05 15:20 UTC by Report Bug Copy Issue Report The assignment to `$temp` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
83
84		return [$type, $name];
85		}
86
87		public function getType()
88		{
89		return $this->_type;
90		}
91
92		public function getName()
93		{
94		return $this->_name;
95		}
96
97		public function getHash()
98		{
99		return $this->_hash;
100		}
101
102		/**
103		* @return Composer
104		*/
105		public static function getCommonComposer()
106		{
107		if (static::$_commonComposer === null) {
108		static::$_commonComposer = (new Factory)->createComposer(
109		new NullIO(),
110		Yii::getAlias('@composer/composer.json'),
		0 ignored issues – show Bug introduced 2016-05-18 12:25 UTC by Report Bug Copy Issue Report It seems like `\Yii::getAlias('@composer/composer.json')` targeting `yii\BaseYii::getAlias()` can also be of type `boolean`; however, `Composer\Factory::createComposer()` does only seem to accept `array\|string\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
111		false,
112		Yii::getAlias('@composer')
113		);
114		}
115
116		return static::$_commonComposer;
117		}
118
119		public function setComposer($value)
120		{
121		$this->_composer = $value;
122		}
123
124		/**
125		* @return Composer
126		*/
127		public function getComposer()
128		{
129		if ($this->_composer === null) {
130		$this->_composer = static::getCommonComposer();
131		}
132
133		return $this->_composer;
134		}
135
136		public function getIO()
137		{
138		if ($this->_io === null) {
139		$this->_io = new NullIO();
140		}
141
142		return $this->_io;
143		}
144
145		/**
146		* findOne.
147		*
148		* @param string $type
149		* @param string $name
150		* @return static\|null
151		*/
152		public static function findOne($type, $name)
153		{
154		$package = new static($type, $name);
155		$package->load();
156
157		return $package;
158		}
159
160		public function load()
161		{
162		$data = $this->getStorage()->readPackage($this);
163		$this->_hash = $data['hash'];
164		$this->_releases = $data['releases'];
165		}
166
167		public function update()
168		{
169		$registry = RegistryFactory::getRegistry($this->getType(), $this->getComposer()->getRepositoryManager());
170		$repo = $registry->buildVcsRepository($this->getName());
171		$this->_releases = $this->prepareReleases($repo);
172		$this->_hash = $this->getStorage()->writePackage($this);
173		}
174
175		/**
176		* @param AssetVcsRepository $repository
177		* @return array
178		*/
179		public function prepareReleases($repository)
180		{
181		$releases = [];
182		foreach ($repository->getPackages() as $package) {
183		$version = $package->getVersion();
184		$release = [
185		'uid' => $this->prepareUid($version),
186		'name' => $this->getFullName(),
187		'version' => $version,
188		];
189		if ($package->getDistUrl()) {
190		$release['dist'] = [
191		'type' => $package->getDistType(),
192		'url' => $package->getDistUrl(),
193		'reference' => $package->getDistReference(),
194		];
195		}
196		if ($package->getSourceUrl()) {
197		$release['source'] = [
198		'type' => $package->getSourceType(),
199		'url' => $package->getSourceUrl(),
200		'reference' => $package->getSourceReference(),
201		];
202		}
203		if ($release['dist'] \|\| $release['source']) {
204		$releases[$version] = $release;
205		}
206		}
207
208		return $releases;
209		}
210
211		public function prepareUid($version)
212		{
213		$known = $this->getSaved()->getRelease($version);
214
215		return isset($known['uid']) ? $known['uid'] : $this->getStorage()->getNextID();
216		}
217
218		public function getReleases()
219		{
220		return $this->_releases;
221		}
222
223		public function getRelease($version)
224		{
225		return isset($this->_releases[$version]) ? $this->_releases[$version] : [];
226		}
227
228		public function getSaved()
229		{
230		if ($this->_saved === null) {
231		$this->_saved = static::findOne($this->getType(), $this->getName());
232		}
233
234		return $this->_saved;
235		}
236
237		public function getStorage()
238		{
239		if ($this->_storage === null) {
240		$this->_storage = Storage::getInstance();
241		}
242
243		return $this->_storage;
244		}
245		}
246

hiqdev / asset-packagist

Push — master ( 5d7641...f3f873 )

AssetPackage::getRelease() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like