ResponseListener::onKernelView() - Code Metrics - Inspection of "Initial base-feature state" - hikaru-shindo/api-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Pascal

created 2018-05-14 17:47 UTC

ResponseListener::onKernelView() A

↳ Parent: ResponseListener

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	12
nc	3
nop	1
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
ccs	13
cts	13
cp	1
crap	3

<?php

declare(strict_types=1);

namespace Saikootau\ApiBundle\Event\Listener;

use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;

class ResponseListener extends MediaTypeListener
{
    private static $noContentMethods = [
        'HEAD',
    ];

    public function onKernelView(GetResponseForControllerResultEvent $event): void
    {
        $controllerResult = $event->getControllerResult();

        if ($controllerResult instanceof Response) {
            return;
        }

        $serializer = $this->getSerializer($event->getRequest());
        $body = '';
        if ($this->isContentAllowed($event->getRequest()->getMethod())) {
            $body = $serializer->serialize($controllerResult);
        }

        $event->setResponse(
            $this->createResponse(
                $body,
                Response::HTTP_OK,
                $serializer->getContentType()
            )
        );
    }

    /**
     * Checks if the response should contain any content.
     *
     * @param string $method
     *
     * @return bool
     */
    private function isContentAllowed(string $method): bool
    {
        return !in_array($method, self::$noContentMethods);
    }

    /**
     * Create a response for the given data.
     *
     * @param string $body
     * @param int    $status
     * @param string $contentType
     *
     * @return Response
     */
    private function createResponse(string $body, int $status, string $contentType): Response
    {
        return new Response(
            $body,
            $status,
            ['Content-Type' => $contentType]
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Saikootau\ApiBundle\Event\Listener;
6
7		use Symfony\Component\HttpFoundation\Response;
8		use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
9
10		class ResponseListener extends MediaTypeListener
11		{
12		private static $noContentMethods = [
13		'HEAD',
14		];
15
16	3	public function onKernelView(GetResponseForControllerResultEvent $event): void
17		{
18	3	$controllerResult = $event->getControllerResult();
19
20	3	if ($controllerResult instanceof Response) {
21	1	return;
22		}
23
24	2	$serializer = $this->getSerializer($event->getRequest());
25	2	$body = '';
26	2	if ($this->isContentAllowed($event->getRequest()->getMethod())) {
27	2	$body = $serializer->serialize($controllerResult);
28		}
29
30	2	$event->setResponse(
31	2	$this->createResponse(
32	2	$body,
33	2	Response::HTTP_OK,
34	2	$serializer->getContentType()
35		)
36		);
37	2	}
38
39		/**
40		* Checks if the response should contain any content.
41		*
42		* @param string $method
43		*
44		* @return bool
45		*/
46	2	private function isContentAllowed(string $method): bool
47		{
48	2	return !in_array($method, self::$noContentMethods);
49		}
50
51		/**
52		* Create a response for the given data.
53		*
54		* @param string $body
55		* @param int $status
56		* @param string $contentType
57		*
58		* @return Response
59		*/
60	2	private function createResponse(string $body, int $status, string $contentType): Response
61		{
62	2	return new Response(
63	2	$body,
64	2	$status,
65	2	['Content-Type' => $contentType]
66		);
67		}
68		}
69

hikaru-shindo / api-bundle

GitHub Access Token became invalid

Pull Request — master (#1)

ResponseListener::onKernelView() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like