ResponseListener::onKernelView() - Code Metrics - Inspection of "Initial base-feature state" - hikaru-shindo/api-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Pascal

created 2018-05-14 07:48 UTC

ResponseListener::onKernelView() A

↳ Parent: ResponseListener

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	12
nc	3
nop	1
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Saikootau\ApiBundle\Event\Listener;

use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;

class ResponseListener extends MediaTypeListener
{
    private static $noContentMethods = [
        'HEAD',
    ];

    public function onKernelView(GetResponseForControllerResultEvent $event): void
    {
        $controllerResult = $event->getControllerResult();

        if ($controllerResult instanceof Response) {
            return;
        }

        if (!$this->isContentAllowed($event->getRequest()->getMethod())) {
            $event->setResponse(
                $this->createEmptyResponse(Response::HTTP_OK)
            );

            return;
        }

        $serializer = $this->getSerializer($event->getRequest());
        $event->setResponse(new Response(
            $serializer->serialize($controllerResult),
            Response::HTTP_OK,
            ['Content-Type' => $serializer->getContentType()]
        ));
    }

    /**
     * Checks if the response should contain any content.
     *
     * @param string $method
     *
     * @return bool
     */
    private function isContentAllowed(string $method): bool
    {
        return !in_array($method, self::$noContentMethods);
    }

    /**
     * Create a response without any body.
     *
     * @param int $status
     *
     * @return Response
     */
    private function createEmptyResponse(int $status): Response
    {
        return new Response(
            '', $status
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Saikootau\ApiBundle\Event\Listener;
6
7			use Symfony\Component\HttpFoundation\Response;
8			use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
9
10			class ResponseListener extends MediaTypeListener
11			{
12			private static $noContentMethods = [
13			'HEAD',
14			];
15
16			public function onKernelView(GetResponseForControllerResultEvent $event): void
17			{
18			$controllerResult = $event->getControllerResult();
19
20			if ($controllerResult instanceof Response) {
21			return;
22			}
23
24			if (!$this->isContentAllowed($event->getRequest()->getMethod())) {
25			$event->setResponse(
26			$this->createEmptyResponse(Response::HTTP_OK)
27			);
28
29			return;
30			}
31
32			$serializer = $this->getSerializer($event->getRequest());
33			$event->setResponse(new Response(
34			$serializer->serialize($controllerResult),
35			Response::HTTP_OK,
36			['Content-Type' => $serializer->getContentType()]
37			));
38			}
39
40			/**
41			* Checks if the response should contain any content.
42			*
43			* @param string $method
44			*
45			* @return bool
46			*/
47			private function isContentAllowed(string $method): bool
48			{
49			return !in_array($method, self::$noContentMethods);
50			}
51
52			/**
53			* Create a response without any body.
54			*
55			* @param int $status
56			*
57			* @return Response
58			*/
59			private function createEmptyResponse(int $status): Response
60			{
61			return new Response(
62			'', $status
63			);
64			}
65			}
66

hikaru-shindo / api-bundle

GitHub Access Token became invalid

Pull Request — master (#1)

ResponseListener::onKernelView() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like