App\Http\Controllers\Frontend\CheckoutController

Complexity

Total Complexity

55

Size/Duplication

Total Lines	301
Duplicated Lines	0 %

Importance

Changes	11
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getEditAddress()	0	28	6
D	postComplete()	0	63	16
B	postCheckoutRegister()	0	79	11
A	postCheckoutLogin()	0	27	4
B	postEditAddress()	0	44	10
B	checkout()	0	48	8

<?php namespace App\Http\Controllers\Frontend;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Hideyo\Ecommerce\Framework\Services\SendingMethod\SendingMethodFacade as SendingMethodService;
use Hideyo\Ecommerce\Framework\Services\PaymentMethod\PaymentMethodFacade as PaymentMethodService;
use Hideyo\Ecommerce\Framework\Services\Client\ClientFacade as ClientService;
use Hideyo\Ecommerce\Framework\Services\Order\OrderFacade as OrderService;
use Hideyo\Ecommerce\Framework\Services\Order\Events\OrderChangeStatus;
use Cart;
use Validator;
use Notification;
use BrowserDetect;

The type BrowserDetect was not found. Maybe you did not declare it correctly or list all dependencies?

use Mail;
use Event;

class CheckoutController extends Controller
{
    public function checkout()
    {
        $sendingMethodsList = SendingMethodService::selectAllActiveByShopId(config()->get('app.shop_id'));

        if (!Cart::getContent()->count()) {
            return redirect()->to('cart');
        }

        $paymentMethodsList = Cart::getConditionsByType('sending_method')->first()->getAttributes()['data']['related_payment_methods_list'];
     
        if(!Cart::getConditionsByType('sending_method')->count()) {
            Notification::error('Selecteer een verzendwijze');
            return redirect()->to('cart');
        }

        if(!Cart::getConditionsByType('payment_method')->count()) {
            Notification::error('Selecteer een betaalwijze');
            return redirect()->to('cart');
        }

        if (auth('web')->guest()) {
            $noAccountUser = session()->get('noAccountUser');
            if ($noAccountUser) {
                if (!isset($noAccountUser['delivery'])) {
                    $noAccountUser['delivery'] = $noAccountUser;
                    session()->put('noAccountUser', $noAccountUser);
                }
  
                return view('frontend.checkout.no-account')->with(array( 
                    'noAccountUser' =>  $noAccountUser, 
                    'sendingMethodsList' => $sendingMethodsList, 
                    'paymentMethodsList' => $paymentMethodsList));
            }
              
             return view('frontend.checkout.login')->with(array(  'sendingMethodsList' => $sendingMethodsList, 'paymentMethodsList' => $paymentMethodsList));
        }

        $user = auth('web')->user();

        if (!$user->clientDeliveryAddress()->count()) {

The method clientDeliveryAddress() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            ClientService::setBillOrDeliveryAddress(config()->get('app.shop_id'), $user->id, $user->clientBillAddress->id, 'delivery');

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing clientBillAddress on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return redirect()->to('cart/checkout');
        }

        return view('frontend.checkout.index')->with(array(
            'user' =>  $user, 
            'sendingMethodsList' => $sendingMethodsList, 
            'paymentMethodsList' => $paymentMethodsList));
    }

    public function postCheckoutLogin(Request $request)
    {
        $validateLogin = ClientService::validateLogin($request->all());

        if ($validateLogin->fails()) {
            foreach ($validateLogin->errors()->all() as $error) {
                Notification::error($error);
            }

            return redirect()->to('cart/checkout')
            ->withErrors(true, 'login')->withInput();

true of type true is incompatible with the type Illuminate\Contracts\Support\MessageProvider|array|string expected by parameter $provider of Illuminate\Http\RedirectResponse::withErrors().

        }

        $userdata = array(
            'email' => $request->get('email'),
            'password' => $request->get('password'),
            'confirmed' => 1,
            'active' => 1,
            'shop_id' => config()->get('app.shop_id')
        );

        if (auth('web')->attempt($userdata)) {
            return redirect()->to('cart/checkout');
        }

        Notification::error(trans('message.error.data-is-incorrect'));
        return redirect()->to('cart/checkout')->withErrors(true, 'login')->withInput(); 
    }

    public function postCheckoutRegister(Request $request)
    {
        if (!Cart::getContent()->count()) {  
            return redirect()->to('cart/checkout');
        }

        $noAccount = true;
        if ($request->get('password')) {
            $noAccount = false;
        } 

        $validateRegister = ClientService::validateRegister($request->all(), $noAccount);

The call to Hideyo\Ecommerce\Framework\Services\Client\ClientService::validateRegister() has too many arguments starting with $noAccount.

        if($validateRegister->fails()) {
            foreach ($validator->errors()->all() as $error) {

The variable $validator seems to be never defined.

                Notification::error($error);
            }

            return redirect()->to('cart/checkout')
            ->withErrors(true, 'register')->withInput();;

true of type true is incompatible with the type Illuminate\Contracts\Support\MessageProvider|array|string expected by parameter $provider of Illuminate\Http\RedirectResponse::withErrors().

        }

        if ($request->get('password')) {
            $registerAttempt = ClientService::validateRegister($request->all(), config()->get('app.shop_id'));

            if ($registerAttempt) {

$registerAttempt is of type Illuminate\Contracts\Validation\Validator, thus it always evaluated to true.

                $register = ClientService::register($request->all(), config()->get('app.shop_id'), true);
            } else {
                $client = ClientService::findByEmail($request->get('email'), config()->get('app.shop_id'));

                if ($client->account_created) {
                    Notification::error('Je hebt al een account. Login aan de linkerkant of vraag een nieuw wachtwoord aan.');
                    return redirect()->to('cart/checkout')->withInput()->withErrors('Dit emailadres is al in gebruik. Je kan links inloggen.', 'register');
                }
                
                $register = ClientService::createAccount($request->all(), config()->get('app.shop_id'));
            }

            if ($register) {
                $data = $register;
                $data['shop'] = app('shop');
        
                Mail::send('frontend.email.register-mail', array('password' => $request->get('password'), 'user' => $data->toArray(), 'billAddress' => $data->clientBillAddress->toArray()), function ($message) use ($data) {
            
                    $message->to($data['email'])->from($data['shop']->email, $data['shop']->title)->subject('Je bent geregistreerd.');
                });

                $userdata = array(
                    'email' => $request->get('email'),
                    'password' => $request->get('password'),
                    'confirmed' => 1,
                    'active' => 1
                );

                auth('web')->attempt($userdata);

                return redirect()->to('cart/checkout')->withErrors('Je bent geregistreerd. Er is een bevestigingsmail gestuurd.', 'login');
            }
            
            Notification::error('Je hebt al een account');
            return redirect()->to('cart/checkout')->withErrors(true, 'register')->withInput();    
        }
        
        $userdata = $request->all();
        unset($userdata['password']);
        $registerAttempt = ClientService::validateRegisterNoAccount($userdata, config()->get('app.shop_id'));

        if ($registerAttempt) {
            $register = ClientService::register($userdata, config()->get('app.shop_id'));   
            $userdata['client_id'] = $register->id;
        } else {
            $client = ClientService::findByEmail($userdata['email'], config()->get('app.shop_id'));
            if ($client) {
                $userdata['client_id'] = $client->id;
            }
        }

        session()->put('noAccountUser', $userdata);
        return redirect()->to('cart/checkout');   
    }

    public function postComplete(Request $request)
    {
        $noAccountUser = session()->get('noAccountUser');
        if (auth('web')->guest() and !$noAccountUser) {
            return view('frontend.checkout.login');
        }

        if (!Cart::getContent()->count()) {        
            return redirect()->to('cart/checkout');
        }

        $data = array(
            'products' => Cart::getContent()->toArray(),
            'price_with_tax' => Cart::getTotalWithTax(false),
            'price_without_tax' => Cart::getTotalWithoutTax(false),
            'comments' => $request->get('comments'),
            'browser_detect' => serialize(BrowserDetect::toArray())
        );

        if (auth('web')->check()) {
            $data['user_id'] = auth('web')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        if ($noAccountUser){
            $data['user_id'] = $noAccountUser['client_id'];
        }     

        if(Cart::getConditionsByType('sending_method')->count()) {
            $data['sending_method'] = Cart::getConditionsByType('sending_method');
        }

        if(Cart::getConditionsByType('sending_method_country_price')->count()) {
            $data['sending_method_country_price'] = Cart::getConditionsByType('sending_method_country_price');
        }

        if(Cart::getConditionsByType('payment_method')->count()) {
            $data['payment_method'] = Cart::getConditionsByType('payment_method');
        }

        $orderInsertAttempt = OrderService::createOrderFrontend($data, config()->get('app.shop_id'), $noAccountUser);

        if ($orderInsertAttempt AND $orderInsertAttempt->count()) {
            if ($orderInsertAttempt->OrderPaymentMethod and $orderInsertAttempt->OrderPaymentMethod->paymentMethod->order_confirmed_order_status_id) {
                $orderStatus = OrderService::updateStatus($orderInsertAttempt->id, $orderInsertAttempt->OrderPaymentMethod->paymentMethod->order_confirmed_order_status_id);
                if ($orderInsertAttempt->OrderPaymentMethod->paymentMethod->order_confirmed_order_status_id) {
                    Event::dispatch(new OrderChangeStatus($orderStatus));

The method dispatch() does not exist on Event.

                }
            }

            session()->put('orderData', $orderInsertAttempt);

            if ($orderInsertAttempt->OrderPaymentMethod and $orderInsertAttempt->OrderPaymentMethod->paymentMethod->payment_external) {
                return redirect()->to('cart/payment');
            }

            app('cart')->clear();
            app('cart')->clearCartConditions();  
            session()->flush('noAccountUser');
            $body = "";
            return view('frontend.checkout.complete')->with(array('body' => $body));            
        }

        return redirect()->to('cart/checkout');
    }

    public function getEditAddress(Request $request, $type) {

The parameter $request is not used and could be removed.

        if (!Cart::getContent()->count()) {        
            return redirect()->to('cart/checkout');
        }              

        if (auth('web')->guest()) {
            $noAccountUser = session()->get('noAccountUser');
            if ($noAccountUser) {
                
                $address = $noAccountUser;
                if ($type == 'delivery') {
                    $address = $noAccountUser['delivery'];
                }

                return view('frontend.checkout.edit-address-no-account')->with(array('type' => $type, 'noAccountUser' =>  $noAccountUser, 'clientAddress' => $address));
            }
        }

        $user = auth('web')->user();

        if ($type == 'delivery') {
            $address = $user->clientDeliveryAddress->toArray();

Accessing clientDeliveryAddress on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        } else {
            $address = $user->clientBillAddress->toArray();

Accessing clientBillAddress on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        return view('frontend.checkout.edit-address')->with(array('type' => $type, 'user' => $user, 'clientAddress' => $address));
    }

    public function postEditAddress(Request $request, $type)
    {
        if (!Cart::getContent()->count()) {        
            return redirect()->to('cart/checkout');
        } 
        
        $validate = ClientService::validateAddress($request->all());

        if ($validate->fails()) {
            foreach ($validate->errors()->all() as $error) {
                Notification::error($error);
            }

            return redirect()->to('cart/edit-address/'.$type)
            ->with(array('type' => $type))->withInput();
        }

        if (auth('web')->guest()) {
            $noAccountUser = session()->get('noAccountUser');
            if ($noAccountUser) {
                if ($type == 'bill') {
                    $noAccountUser = array_merge($noAccountUser, $request->all());
                } elseif ($type == 'delivery') {
                    $noAccountUser['delivery'] = array_merge($noAccountUser['delivery'], $request->all());
                }

                session()->put('noAccountUser', $noAccountUser);
            }
        } else {
            $user = auth('web')->user();
            $id = $user->clientBillAddress->id;

Accessing clientBillAddress on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            if ($type == 'delivery') {
                $id = $user->clientDeliveryAddress->id;

Accessing clientDeliveryAddress on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            }

            if ($user->clientDeliveryAddress->id == $user->clientBillAddress->id) {
                $clientAddress = ClientService::createAddress($request->all(), $user->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                ClientService::setBillOrDeliveryAddress(config()->get('app.shop_id'), $user->id, $clientAddress->id, $type);
            } else {
                $clientAddress = ClientService::editAddress($user->id, $id, $request->all());

The assignment to $clientAddress is dead and can be removed.

            }
        }

        return redirect()->to('cart/checkout');        
    }
}