App\Http\Controllers\Backend\TaxRateController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	3	1
A	edit()	0	3	1
A	index()	0	14	2
A	store()	0	4	1
A	destroy()	0	6	2
A	update()	0	4	1

<?php namespace App\Http\Controllers\Backend;

use App\Http\Controllers\Controller;
use Hideyo\Ecommerce\Framework\Services\TaxRate\TaxRateFacade as TaxRateService;
use Illuminate\Http\Request;
use Form;
use DataTables;

class TaxRateController extends Controller
{
    public function index(Request $request)
    {
        if ($request->wantsJson()) {
            $query = TaxRateService::getModel()->where('shop_id', '=', auth('hideyobackend')->user()->selected_shop_id);

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $datatables = DataTables::of($query)->addColumn('action', function ($query) {
                $deleteLink = Form::deleteajax(url()->route('tax-rate.destroy', $query->id), 'Delete', '', array('class'=>'btn btn-sm btn-danger'), $query->title);
                $links = '<a href="'.url()->route('tax-rate.edit', $query->id).'" class="btn btn-sm btn-success"><i class="fi-pencil"></i>Edit</a>  '.$deleteLink;
                return $links;
            });

            return $datatables->make(true);
        }
        
        return view('backend.tax_rate.index');
    }

    public function create()
    {
        return view('backend.tax_rate.create');
    }

    public function store(Request $request)
    {
        $result = TaxRateService::create($request->all());
        return TaxRateService::notificationRedirect('tax-rate.index', $result, 'The tax rate was inserted.');
    }

    public function edit($taxRateId)
    {
        return view('backend.tax_rate.edit')->with(array('taxRate' => TaxRateService::find($taxRateId)));
    }

    public function update(Request $request, $taxRateId)
    {
        $result = TaxRateService::updateById($request->all(), $taxRateId);
        return TaxRateService::notificationRedirect('tax-rate.index', $result, 'The tax rate was updated.');
    }

    public function destroy($taxRateId)
    {
        $result = TaxRateService::destroy($taxRateId);
        if ($result) {
            flash('The tax rate was deleted.');
            return redirect()->route('tax-rate.index');
        }
    }
}