App\Http\Controllers\Backend\ProductCategoryController

Complexity

Total Complexity

40

Size/Duplication

Total Lines	232
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	1

17 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	4	1
A	create()	0	3	1
B	index()	0	63	10
A	editSeo()	0	3	1
A	tree()	0	3	1
A	ajaxCategory()	0	4	2
A	generateInput()	0	11	3
A	edit()	0	3	1
B	ajaxMoveNode()	0	33	6
A	update()	0	4	1
A	ajaxCategories()	0	7	2
A	ajaxChildrenTree()	0	19	3
A	destroy()	0	7	2
A	changeActive()	0	4	1
A	editHighlight()	0	4	1
A	refactorAllImages()	0	4	1
A	ajaxRootTree()	0	19	3

<?php namespace App\Http\Controllers\Backend;

/**
 * ProductCategoryController
 *
 * This is the controller of the product categories of the shop
 * @author Matthijs Neijenhuijs <matthijs@hideyo.io>
 * @version 0.1
 */

use App\Http\Controllers\Controller;
use Dutchbridge\Datatable\ProductCategoryDatatable;

The type Dutchbridge\Datatable\ProductCategoryDatatable was not found. Maybe you did not declare it correctly or list all dependencies?

use Hideyo\Ecommerce\Framework\Services\Product\ProductFacade as ProductService;
use Hideyo\Ecommerce\Framework\Services\ProductCategory\ProductCategoryFacade as ProductCategoryService;
use Illuminate\Http\Request;
use DataTables;
use Form;

class ProductCategoryController extends Controller
{
    public function index(Request $request)
    {
        if ($request->wantsJson()) {

            $productCategory = ProductCategoryService::getModel()->where('shop_id', '=', auth('hideyobackend')->user()->selected_shop_id);

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            
            $datatables = DataTables::of($productCategory)

            ->addColumn('image', function ($productCategory) {
                if ($productCategory->productCategoryImages->count()) {
                    return '<img src="/files/product_category/100x100/'.$productCategory->id.'/'.$productCategory->productCategoryImages->first()->file.'"  />';
                }
            })

            ->addColumn('title', function ($productCategory) {

                $categoryTitle = $productCategory->title;
                if ($productCategory->refProductCategory) {
                    $categoryTitle = '<strong>Redirect:</strong> '.$productCategory->title.' &#8594; '.$productCategory->refProductCategory->title;
                } elseif ($productCategory->isRoot()) {
                    $categoryTitle = '<strong>Root:</strong> '.$productCategory->title;
                } elseif ($productCategory->isChild()) {
                    $categoryTitle = '<strong>Child:</strong> '.$productCategory->title;
                }
                
                return $categoryTitle;
            })

            ->addColumn('products', function ($productCategory) {
                return $productCategory->products->count();
            })
            ->addColumn('parent', function ($productCategory) {
             
                if ($productCategory->parent()->count()) {
                    return $productCategory->parent()->first()->title;
                }
            })

            ->addColumn('active', function ($product) {
                if ($product->active) {
                    return '<a href="#" class="change-active" data-url="/admin/product-category/change-active/'.$product->id.'"><span class="glyphicon glyphicon-ok icon-green"></span></a>';
                }
                
                return '<a href="#" class="change-active" data-url="/admin/product-category/change-active/'.$product->id.'"><span class="glyphicon glyphicon-remove icon-red"></span></a>';
            })


            ->addColumn('seo', function ($productCategory) {
                if ($productCategory->meta_title && $productCategory->meta_description) {
                    return '<i class="fa fa-check"></i>';
                }
            })
            ->addColumn('action', function ($productCategory) {
                $deleteLink = Form::deleteajax(url()->route('product-category.destroy', $productCategory->id), 'Delete', '', array('class'=>'btn btn-sm btn-danger'), $productCategory->title);
                $links = '<a href="'.url()->route('product-category.edit', $productCategory->id).'" class="btn btn-sm btn-success"><i class="entypo-pencil"></i>Edit</a>  '.$deleteLink;
            
                return $links;
            });

            return $datatables->rawColumns(['active', 'title', 'action'])->make(true);
        }
        
        return view('backend.product_category.index')->with(array('productCategory' =>  ProductCategoryService::selectAll()));
    }

    public function refactorAllImages()
    {
        $this->productCategoryImage->refactorAllImagesByShopId(auth('hideyobackend')->user()->selected_shop_id);

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

The property productCategoryImage does not exist on App\Http\Controllers\Backend\ProductCategoryController. Did you maybe forget to declare it?

        return redirect()->route('product-category.index');
    }

    public function tree()
    {
        return view('backend.product_category.tree')->with(array('productCategory' =>  ProductCategoryService::selectAll(), 'tree' => ProductCategoryService::entireTreeStructure(auth('hideyobackend')->user()->shop->id)->toArray()));

Accessing shop on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function ajaxCategories(Request $request)
    {
        $query = $request->get('q');
        $selectedId = $request->get('selectedId');

        if ($request->wantsJson()) {
            return response()->json(ProductCategoryService::ajaxSearchByTitle($query, $selectedId));
        }
    }

    public function ajaxCategory(Request $request, $productCategoryId)
    {
        if ($request->wantsJson()) {
            return response()->json(ProductCategoryService::find($productCategoryId));
        }
    }

    public function generateInput($array)
    {      
        if (empty($array['redirect_product_category_id'])) {
            $array['redirect_product_category_id'] = null;
        }

        if (empty($array['parent_id'])) {
            $array['parent_id'] = null;
        }

        return $array;
    }

    public function create()
    {
        return view('backend.product_category.create')->with(array('categories' => ProductCategoryService::selectAll()->pluck('title', 'id')));
    }

    public function store(Request $request)
    {
        $result  = ProductCategoryService::create($this->generateInput($request->all()));
        return ProductCategoryService::notificationRedirect('product-category.index', $result, 'The product category was inserted.');
    }

    public function edit($productCategoryId)
    {
        return view('backend.product_category.edit')->with(array('productCategory' => ProductCategoryService::find($productCategoryId), 'categories' => ProductCategoryService::selectAll()->pluck('title', 'id')));
    }

    public function editHighlight($productCategoryId)
    {
        $products = ProductService::selectAll()->pluck('title', 'id');
        return view('backend.product_category.edit-highlight')->with(array('products' => $products, 'productCategory' => ProductCategoryService::find($productCategoryId), 'categories' => ProductCategoryService::selectAll()->pluck('title', 'id')));
    }

    public function editSeo($productCategoryId)
    {
        return view('backend.product_category.edit_seo')->with(array('productCategory' => ProductCategoryService::find($productCategoryId), 'categories' => ProductCategoryService::selectAll()->pluck('title', 'id')));
    }

    public function update(Request $request, $productCategoryId)
    {
        $result  = ProductCategoryService::updateById($this->generateInput($request->all()), $productCategoryId);
        return ProductCategoryService::notificationRedirect('product-category.index', $result, 'The product category was updated.');
    }

    public function destroy($productCategoryId)
    {
        $result  = ProductCategoryService::destroy($productCategoryId);

        if ($result) {
            flash('Category was deleted.');
            return redirect()->route('product-category.index');
        }
    }

    public function ajaxRootTree()
    {
        $tree = ProductCategoryService::entireTreeStructure(auth('hideyobackend')->user()->shop->id);

Accessing shop on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        foreach ($tree as $key => $row) {
            $children = false;
            if ($row->children->count()) {
                $children = true;
            }

            $treeData[] = array(
                'id' => $row->id,
                'text' => $row->title,
                'children' => $children,
                'type' => 'root'

            );
        }

        return response()->json($treeData);

The variable $treeData seems to be defined by a foreach iteration on line 173. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    public function ajaxChildrenTree(Request $request)
    {
        $productCategoryId = $request->get('id');
        $category = ProductCategoryService::find($productCategoryId);

        foreach ($category->children()->get() as $key => $row) {
            $children = false;
            if ($row->children->count()) {
                $children = true;
            }

            $treeData[] = array(
                'id' => $row->id,
                'text' => $row->title,
                'children' => $children
            );
        }

        return response()->json($treeData);

The variable $treeData seems to be defined by a foreach iteration on line 196. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    public function changeActive($productCategoryId)
    {
        $result = ProductCategoryService::changeActive($productCategoryId);
        return response()->json($result);
    }

    public function ajaxMoveNode(Request $request)
    {
        $productCategoryId = $request->get('id');
        $position = $request->get('position');
        $node = ProductCategoryService::find($productCategoryId);
        $parent = $request->get('parent');

        if ($parent != '#') {
            $parent = ProductCategoryService::find($parent);
            if ($position == 0) {

It seems like you are loosely comparing $position of type mixed|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

                $node->makeFirstChildOf($parent);
            } elseif ($parent->children()->count()) {
                $node->makeLastChildOf($parent);
                foreach ($parent->children()->get() as $key => $row) {
                    $positionKey =  $position - 1;
                    if ($key == $positionKey) {
                        $node->moveToRightOf($row);
                    }
                }
            } else {
                $node->makeFirstChildOf($parent);
            }
        } else {
            $node->makeRoot();
        }

        $node = ProductCategoryService::find($productCategoryId);
        $arrayPosition = $node->siblingsAndSelf()->get()->toArray();

        $positionToMove = $arrayPosition[$position];
        
        $otherNode = ProductCategoryService::find($positionToMove['id']);
        $node->moveToLeftOf($otherNode);
    }
}