App\Http\Controllers\Backend\PaymentMethodController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	4	1
A	update()	0	4	1
A	destroy()	0	7	2
A	index()	0	35	5
A	edit()	0	7	1
A	create()	0	6	1

<?php namespace App\Http\Controllers\Backend;

/**
 * PaymentMethodController
 *
 * This is the controller for the shop payment methods
 * @author Matthijs Neijenhuijs <matthijs@hideyo.io>
 * @version 0.1
 */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Form;
use DataTables;
use Hideyo\Ecommerce\Framework\Services\PaymentMethod\PaymentMethodFacade as PaymentMethodService;
use Hideyo\Ecommerce\Framework\Services\TaxRate\TaxRateFacade as TaxRateService;
use Hideyo\Ecommerce\Framework\Services\Order\OrderStatusFacade as OrderStatusService;

class PaymentMethodController extends Controller
{
    public function index(Request $request)
    {
        if ($request->wantsJson()) {

            $query = PaymentMethodService::getModel()->where('shop_id', '=', auth('hideyobackend')->user()->selected_shop_id)

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            ->with(array('orderConfirmedOrderStatus', 'orderPaymentCompletedOrderStatus', 'orderPaymentFailedOrderStatus'));
            
            $datatables = DataTables::of($query)

            ->addColumn('orderconfirmed', function ($query) {
                if ($query->orderConfirmedOrderStatus) {
                    return $query->orderConfirmedOrderStatus->title;
                }
            })
            ->addColumn('paymentcompleted', function ($query) {
                if ($query->orderPaymentCompletedOrderStatus) {
                    return $query->orderPaymentCompletedOrderStatus->title;
                }
            })
            ->addColumn('paymentfailed', function ($query) {
                if ($query->orderPaymentFailedOrderStatus) {
                    return $query->orderPaymentFailedOrderStatus->title;
                }
            })
            ->addColumn('action', function ($query) {
                $deleteLink = Form::deleteajax(url()->route('payment-method.destroy', $query->id), 'Delete', '', array('class'=>'btn btn-sm btn-danger'));
                $links = '<a href="'.url()->route('payment-method.edit', $query->id).'" class="btn btn-sm btn-success"><i class="fi-pencil"></i>Edit</a>  '.$deleteLink;
                return $links;
            });


            return $datatables->make(true);
        }
        
        return view('backend.payment_method.index')->with('paymentMethod', PaymentMethodService::selectAll());
    }

    public function create()
    {
        return view('backend.payment_method.create')->with(
            array(
                'taxRates' => TaxRateService::selectAll()->pluck('title', 'id'),
                'orderStatuses' => OrderStatusService::selectAll()->pluck('title', 'id')                
            )
        );
    }

    public function store(Request $request)
    {
        $result  = PaymentMethodService::create($request->all());
        return PaymentMethodService::notificationRedirect('payment-method.index', $result, 'The payment method was inserted.');
    }

    public function edit($paymentMethodId)
    {
        return view('backend.payment_method.edit')->with(
            array(
                'paymentMethod' => PaymentMethodService::find($paymentMethodId),
                'taxRates' => TaxRateService::selectAll()->pluck('title', 'id'),
                'orderStatuses' => OrderStatusService::selectAll()->pluck('title', 'id')
            )
        );
    }

    public function update(Request $request, $paymentMethodId)
    {
        $result  = PaymentMethodService::updateById($request->all(), $paymentMethodId);
        return PaymentMethodService::notificationRedirect('payment-method.index', $result, 'The payment method was updated.');
    }

    public function destroy($paymentMethodId)
    {
        $result  = PaymentMethodService::destroy($paymentMethodId);

        if ($result) {
            flash('The payment method was deleted.');
            return redirect()->route('payment-method.index');
        }
    }
}