App\Http\Controllers\Backend\OrderStatusController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	4	1
A	update()	0	4	1
A	index()	0	26	3
A	edit()	0	11	1
A	destroy()	0	7	2
A	create()	0	3	1

<?php namespace App\Http\Controllers\Backend;

/**
 * OrderStatusController
 *
 * This is the controller of the order statuses of the shop
 * @author Matthijs Neijenhuijs <matthijs@hideyo.io>
 * @version 0.1
 */

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Form;
use Hideyo\Ecommerce\Framework\Services\Order\OrderStatusEmailTemplateFacade as OrderStatusEmailTemplateService;
use Hideyo\Ecommerce\Framework\Services\Order\OrderStatusFacade as OrderStatusService;

class OrderStatusController extends Controller
{
    public function index(Request $request)
    {
        if ($request->wantsJson()) {

            $query = OrderStatusService::getModel()->where('shop_id', '=', auth('hideyobackend')->user()->selected_shop_id);

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            
            $datatables = \DataTables::of($query)
            ->addColumn('title', function ($query) {
     
                if ($query->color) {
                    return '<span style="background-color:'.$query->color.'; padding: 10px; line-height:30px; text-align:center; color:white;">'.$query->title.'</span>';
                }
                
                return $query->title;
            })
            ->addColumn('action', function ($query) {
                $deleteLink = Form::deleteajax('/admin/order-status/'. $query->id, 'Delete', '', array('class'=>'btn btn-default btn-sm btn-danger'));
                $links = '<a href="/admin/order-status/'.$query->id.'/edit" class="btn btn-default btn-sm btn-success"><i class="entypo-pencil"></i>Edit</a>  '.$deleteLink;
            
                return $links;
            });

            return $datatables->rawColumns(['title', 'action'])->make(true);
        }
        
        return view('backend.order-status.index')->with('content', OrderStatusService::selectAll());
    }

    public function create()
    {
        return view('backend.order-status.create')->with(array('templates' => OrderStatusEmailTemplateService::selectAllByShopId(auth('hideyobackend')->user()->selected_shop_id)->pluck('title', 'id')));

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function store(Request $request)
    {
        $result  = OrderStatusService::create($request->all());
        return OrderStatusService::notificationRedirect('order-status.index', $result, 'The order status was inserted.');
    }

    public function edit($orderStatusId)
    {
        $orderStatus = OrderStatusService::find($orderStatusId);

        $populatedData = array();
           
        return view('backend.order-status.edit')->with(
            array(
            'orderStatus' => $orderStatus,
            'populatedData' => $populatedData,
            'templates' => OrderStatusEmailTemplateService::selectAllByShopId(auth('hideyobackend')->user()->selected_shop_id)->pluck('title', 'id')

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            )
        );
    }

    public function update(Request $request, $orderStatusId)
    {
        $result  = OrderStatusService::updateById($request->all(), $orderStatusId);
        return OrderStatusService::notificationRedirect('order-status.index', $result, 'The order status was updated.');
    }

    public function destroy($orderStatusId)
    {
        $result  = OrderStatusService::destroy($orderStatusId);

        if ($result) {
            flash('The order status was deleted.');
            return redirect()->route('order-status.index');
        }
    }
}