App\Http\Controllers\Backend\ExtraFieldController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	3	1
A	store()	0	4	1
A	index()	0	32	4
A	update()	0	4	1
A	destroy()	0	7	2
A	edit()	0	3	1

<?php namespace App\Http\Controllers\Backend;

/**
 * ExtraFieldController
 *
 * This is the controller of the product weight types of the shop
 * @author Matthijs Neijenhuijs <matthijs@hideyo.io>
 * @version 0.1
 */

use App\Http\Controllers\Controller;

use Hideyo\Ecommerce\Framework\Services\ExtraField\ExtraFieldFacade as ExtraFieldService;
use Hideyo\Ecommerce\Framework\Services\ProductCategory\ProductCategoryFacade as ProductCategoryService;

use Illuminate\Http\Request;
use DataTables;
use Form;

class ExtraFieldController extends Controller
{
    public function index(Request $request)
    {
        if ($request->wantsJson()) {

            $query = ExtraFieldService::getModel()->where('shop_id', '=', auth('hideyobackend')->user()->selected_shop_id);

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            
            $datatables = DataTables::of($query)

            ->addColumn('category', function ($query) {
                if ($query->categories) {
                    $output = array();
                    foreach ($query->categories as $categorie) {
                        $output[] = $categorie->title;
                    }

                    return implode(' | ', $output);
                }
            })

            ->addColumn('action', function ($query) {
                $deleteLink = Form::deleteajax(url()->route('extra-field.destroy', $query->id), 'Delete', '', array('class'=>'btn btn-default btn-sm btn-danger'));
                $links = '<a href="'.url()->route('extra-field.values.index', $query->id).'" class="btn btn-default btn-sm btn-info"><i class="entypo-pencil"></i>'.$query->values->count().' values</a>
                 <a href="'.url()->route('extra-field.edit', $query->id).'" class="btn btn-default btn-sm btn-success"><i class="entypo-pencil"></i>Edit</a> 
                '.$deleteLink;
            
                return $links;
            });

            return $datatables->make(true);
        }
        
        return view('backend.extra-field.index')->with('extraField', ExtraFieldService::selectAll());
    }

    public function create()
    {
        return view('backend.extra-field.create')->with(array('productCategories' => ProductCategoryService::selectAll()->pluck('title', 'id')));
    }

    public function store(Request $request)
    {
        $result  = ExtraFieldService::create($request->all());
        return ExtraFieldService::notificationRedirect('extra-field.index', $result, 'The extra field was inserted.');
    }

    public function edit($id)
    {
        return view('backend.extra-field.edit')->with(array('extraField' => ExtraFieldService::find($id), 'productCategories' => ProductCategoryService::selectAll()->pluck('title', 'id')));
    }

    public function update(Request $request, $id)
    {
        $result  = ExtraFieldService::updateById($request->all(), $id);
        return ExtraFieldService::notificationRedirect('extra-field.index', $result, 'The extra field was updated.');
    }

    public function destroy($id)
    {
        $result  = ExtraFieldService::destroy($id);

        if ($result) {
            flash('Extra field was deleted.');
            return redirect()->route('extra-field.index');
        }
    }
}