App\Http\Controllers\Backend\ContentGroupController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	4	1
A	index()	0	20	2
A	edit()	0	3	1
A	destroy()	0	7	2
A	update()	0	4	1
A	create()	0	3	1

<?php namespace App\Http\Controllers\Backend;

/**
 * ContentGroupController
 *
 * This is the controller of the content groups of the shop
 * @author Matthijs Neijenhuijs <matthijs@hideyo.io>
 * @version 0.1
 */

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use DataTables;
use Form;

use Hideyo\Ecommerce\Framework\Services\Content\ContentFacade as ContentService;

class ContentGroupController extends Controller
{
    public function index(Request $request)
    {
        if ($request->wantsJson()) {

            $query = ContentService::getGroupModel()
            ->select(['id', 'title'])
            ->where('shop_id', '=', auth('hideyobackend')->user()->selected_shop_id);

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $datatables = DataTables::of($query)
            ->addColumn('action', function ($query) {
                $deleteLink = Form::deleteajax(url()->route('content-group.destroy', $query->id), 'Delete', '', array('class'=>'btn btn-default btn-sm btn-danger'));
                $links = '<a href="'.url()->route('content-group.edit', $query->id).'" class="btn btn-default btn-sm btn-success"><i class="entypo-pencil"></i>Edit</a>  '.$deleteLink;
            
                return $links;
            });

            return $datatables->make(true);
        }
        
        return view('backend.content_group.index')->with('contentGroup', ContentService::selectAll());
    }

    public function create()
    {
        return view('backend.content_group.create')->with(array());
    }

    public function store(Request $request)
    {
        $result  = ContentService::createGroup($request->all());
        return ContentService::notificationRedirect('content-group.index', $result, 'The content group was inserted.');
    }

    public function edit($contentGroupId)
    {
        return view('backend.content_group.edit')->with(array('contentGroup' => ContentService::findGroup($contentGroupId)));
    }

    public function update(Request $request, $contentGroupId)
    {
        $result  = ContentService::updateGroupById($request->all(), $contentGroupId);
        return ContentService::notificationRedirect('content-group.index', $result, 'The content group was updated.');
    }

    /**
     * Remove the specified resource from storage
     * @param  int  $contentGroupId
     * @return Redirect
     */
    public function destroy($contentGroupId)
    {
        $result  = ContentService::destroyGroup($contentGroupId);

        if ($result) {
            flash('The content was deleted.');
            return redirect()->route('content-group.index');

The expression return redirect()->route('content-group.index') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Backend\Redirect.

        }
    }
}