hideyo /
ecommerce-framework
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 77 |
| Code Lines | 67 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 10 | public function run() |
||
| 11 | { |
||
| 12 | $productCategory = new ProductCategory; |
||
| 13 | |||
| 14 | DB::table($productCategory->getTable())->delete(); |
||
| 15 | $shop = Shop::where('title', '=', 'hideyo')->first(); |
||
| 16 | |||
| 17 | $productCategory->active = 1; |
||
| 18 | $productCategory->title = 'Pants'; |
||
| 19 | $productCategory->short_description = 'Great pants'; |
||
| 20 | $productCategory->description = '<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis erat est, mollis vel laoreet sit amet, facilisis et magna. Mauris ultricies bibendum arcu sit amet tristique. Vivamus consequat enim at arcu iaculis blandit. Sed vestibulum metus nec nulla lacinia, nec ultrices ligula pellentesque. Suspendisse et consectetur est. Maecenas viverra metus et est iaculis, id scelerisque nisl hendrerit. Aliquam efficitur sem mi, non volutpat neque consectetur facilisis. Morbi eget nunc rutrum, dictum lectus sit amet, molestie lacus.</p>'; |
||
| 21 | $productCategory->meta_title = 'Pants'; |
||
| 22 | $productCategory->meta_description = 'Great pants'; |
||
| 23 | $productCategory->shop_id = $shop->id; |
||
| 24 | $productCategory->save(); |
||
| 25 | |||
| 26 | $productCategory2 = new ProductCategory; |
||
| 27 | $productCategory2->active = 1; |
||
| 28 | $productCategory2->title = 'T-shirts'; |
||
| 29 | $productCategory2->short_description = 'Soft t-shirts'; |
||
| 30 | $productCategory2->description = '<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis erat est, mollis vel laoreet sit amet, facilisis et magna. Mauris ultricies bibendum arcu sit amet tristique. Vivamus consequat enim at arcu iaculis blandit. Sed vestibulum metus nec nulla lacinia, nec ultrices ligula pellentesque. Suspendisse et consectetur est. Maecenas viverra metus et est iaculis, id scelerisque nisl hendrerit. Aliquam efficitur sem mi, non volutpat neque consectetur facilisis. Morbi eget nunc rutrum, dictum lectus sit amet, molestie lacus.</p>'; |
||
| 31 | $productCategory2->meta_title = 'T-shirts'; |
||
| 32 | $productCategory2->meta_description = 'Soft t-shirts'; |
||
| 33 | $productCategory2->shop_id = $shop->id; |
||
| 34 | $productCategory2->save(); |
||
| 35 | |||
| 36 | $productCategory3 = new ProductCategory; |
||
| 37 | $productCategory3->active = 1; |
||
| 38 | $productCategory3->title = 'Underwear'; |
||
| 39 | $productCategory3->short_description = 'Good underwear'; |
||
| 40 | $productCategory3->description = '<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis erat est, mollis vel laoreet sit amet, facilisis et magna. Mauris ultricies bibendum arcu sit amet tristique. Vivamus consequat enim at arcu iaculis blandit. Sed vestibulum metus nec nulla lacinia, nec ultrices ligula pellentesque. Suspendisse et consectetur est. Maecenas viverra metus et est iaculis, id scelerisque nisl hendrerit. Aliquam efficitur sem mi, non volutpat neque consectetur facilisis. Morbi eget nunc rutrum, dictum lectus sit amet, molestie lacus.</p>'; |
||
| 41 | $productCategory3->meta_title = 'Underwear'; |
||
| 42 | $productCategory3->meta_description = 'Good underwear'; |
||
| 43 | $productCategory3->shop_id = $shop->id; |
||
| 44 | $productCategory3->save(); |
||
| 45 | |||
| 46 | $productCategory4 = new ProductCategory; |
||
| 47 | $productCategory4->active = 1; |
||
| 48 | $productCategory4->title = 'Dresses'; |
||
| 49 | $productCategory4->short_description = 'Lovely dresses'; |
||
| 50 | $productCategory4->description = '<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis erat est, mollis vel laoreet sit amet, facilisis et magna. Mauris ultricies bibendum arcu sit amet tristique. Vivamus consequat enim at arcu iaculis blandit. Sed vestibulum metus nec nulla lacinia, nec ultrices ligula pellentesque. Suspendisse et consectetur est. Maecenas viverra metus et est iaculis, id scelerisque nisl hendrerit. Aliquam efficitur sem mi, non volutpat neque consectetur facilisis. Morbi eget nunc rutrum, dictum lectus sit amet, molestie lacus.</p>'; |
||
| 51 | $productCategory4->meta_title = 'Dresses'; |
||
| 52 | $productCategory4->meta_description = 'Lovely dresses'; |
||
| 53 | $productCategory4->shop_id = $shop->id; |
||
| 54 | $productCategory4->save(); |
||
| 55 | |||
| 56 | $productCategory5 = new ProductCategory; |
||
| 57 | $productCategory5->active = 1; |
||
| 58 | $productCategory5->title = 'Hats'; |
||
| 59 | $productCategory5->short_description = 'Nice hats'; |
||
| 60 | $productCategory5->description = '<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis erat est, mollis vel laoreet sit amet, facilisis et magna. Mauris ultricies bibendum arcu sit amet tristique. Vivamus consequat enim at arcu iaculis blandit. Sed vestibulum metus nec nulla lacinia, nec ultrices ligula pellentesque. Suspendisse et consectetur est. Maecenas viverra metus et est iaculis, id scelerisque nisl hendrerit. Aliquam efficitur sem mi, non volutpat neque consectetur facilisis. Morbi eget nunc rutrum, dictum lectus sit amet, molestie lacus.</p>'; |
||
| 61 | $productCategory5->meta_title = 'Hats'; |
||
| 62 | $productCategory5->meta_description = 'Nice hats'; |
||
| 63 | $productCategory5->shop_id = $shop->id; |
||
| 64 | $productCategory5->save(); |
||
| 65 | |||
| 66 | $productCategory6 = new ProductCategory; |
||
| 67 | $productCategory6->active = 1; |
||
| 68 | $productCategory6->title = 'Leather hats'; |
||
| 69 | $productCategory6->short_description = 'Leather hats'; |
||
| 70 | $productCategory6->description = '<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis erat est, mollis vel laoreet sit amet, facilisis et magna. Mauris ultricies bibendum arcu sit amet tristique. Vivamus consequat enim at arcu iaculis blandit. Sed vestibulum metus nec nulla lacinia, nec ultrices ligula pellentesque. Suspendisse et consectetur est. Maecenas viverra metus et est iaculis, id scelerisque nisl hendrerit. Aliquam efficitur sem mi, non volutpat neque consectetur facilisis. Morbi eget nunc rutrum, dictum lectus sit amet, molestie lacus.</p>'; |
||
| 71 | $productCategory6->meta_title = 'Hats'; |
||
| 72 | $productCategory6->meta_description = 'Leather hats'; |
||
| 73 | $productCategory6->shop_id = $shop->id; |
||
| 74 | $productCategory6->parent_id = $productCategory5->id; |
||
| 75 | $productCategory6->save(); |
||
| 76 | |||
| 77 | $productCategory7 = new ProductCategory; |
||
| 78 | $productCategory7->active = 1; |
||
| 79 | $productCategory7->title = 'Cotton hats'; |
||
| 80 | $productCategory7->short_description = 'Cotton hats'; |
||
| 81 | $productCategory7->description = '<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis erat est, mollis vel laoreet sit amet, facilisis et magna. Mauris ultricies bibendum arcu sit amet tristique. Vivamus consequat enim at arcu iaculis blandit. Sed vestibulum metus nec nulla lacinia, nec ultrices ligula pellentesque. Suspendisse et consectetur est. Maecenas viverra metus et est iaculis, id scelerisque nisl hendrerit. Aliquam efficitur sem mi, non volutpat neque consectetur facilisis. Morbi eget nunc rutrum, dictum lectus sit amet, molestie lacus.</p>'; |
||
| 82 | $productCategory7->meta_title = 'Hats'; |
||
| 83 | $productCategory7->meta_description = 'Cotton hats'; |
||
| 84 | $productCategory7->shop_id = $shop->id; |
||
| 85 | $productCategory7->parent_id = $productCategory5->id; |
||
| 86 | $productCategory7->save(); |
||
| 87 | |||
| 90 |
