Hideyo\Ecommerce\Framework\Services\Product\ProductService::createImage()

Complexity

Conditions	12
Paths	37

Size

Total Lines	70
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function createImage(array $attributes, $productId)
    {
        $userId = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $shopId = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $shop = ShopService::find($shopId);
        $attributes['modified_by_user_id'] = $userId;

        $destinationPath = $this->storageImagePath.$productId;
        $attributes['user_id'] = $userId;
        $attributes['product_id'] = $productId;

        $rules = array(
            'file'=>'required|image|max:1000',
            'rank' => 'required'
        );

        foreach ($attributes['files'] as $file) {

            $attributes['file'] = $file;
            $validator = Validator::make($attributes, $rules);

            if ($validator->fails()) {
                return $validator;
            }

            $attributes['extension'] = $file->getClientOriginalExtension();
            $attributes['size'] = $file->getSize();
            $filename = str_replace(" ", "_", strtolower($file->getClientOriginalName()));
            $uploadSuccess = $file->move($destinationPath, $filename);

            if ($uploadSuccess) {
                $attributes['file'] = $filename;
                $attributes['path'] = $uploadSuccess->getRealPath();
                $file = $this->repo->getImageModel();
                $file->fill($attributes);
                $file->save();
                if ($shop->thumbnail_square_sizes) {
                    $sizes = explode(',', $shop->thumbnail_square_sizes);
                    if ($sizes) {

The expression $sizes of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                        foreach ($sizes as $valueSize) {
                            $image = Image::make($uploadSuccess->getRealPath());
                            $explode = explode('x', $valueSize);

                            if ($image->width() >= $explode[0] and $image->height() >= $explode[1]) {
                                $image->resize($explode[0], $explode[1]);
                            }

                            if (!File::exists($this->publicImagePath.$valueSize."/".$productId."/")) {
                                File::makeDirectory($this->publicImagePath.$valueSize."/".$productId."/", 0777, true);
                            }

                            $image->interlace();

                            $image->save($this->publicImagePath.$valueSize."/".$productId."/".$filename);
                        }
                    }
                }
            } 
        }

        if (isset($attributes['productAttributes'])) {
            $file->relatedProductAttributes()->sync($attributes['productAttributes']);

The variable $file seems to be defined by a foreach iteration on line 130. Are you sure the iterator is never empty, otherwise this variable is not defined?

        }

        if (isset($attributes['attributes'])) {
            $this->model->relatedAttributes()->sync($attributes['attributes']);

The property model does not exist on Hideyo\Ecommerce\Framework\Services\Product\ProductService. Did you maybe forget to declare it?

        }

        $file->save();
        return $file;
    }
}