Hideyo\Ecommerce\Framework\Repositories\InvoiceRepository::generateInvoiceFromOrder()

Complexity

Conditions	14
Paths	13

Size

Total Lines	86
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function generateInvoiceFromOrder($orderId)
    {        
        $order = $this->order->find($orderId);

        if ($order->count()) {
            $attributes = $order->toArray();
            $attributes['order_id'] = $order->id;

            $validator = Validator::make($attributes, $this->rules());

            if ($validator->fails()) {
                return $validator;
            }

            $this->model->fill($attributes);
            $this->model->save();
        
            if ($this->model->id) {
                if ($order->products) {
                    foreach ($order->products as $product) {
                        $product = $product->toArray();
                        $product['product_id'] = $product['product_id'];

                        if (isset($product['product_combination_id'])) {
                            $product['product_attribute_id'] = $product['product_combination_id'];
                            $productCombinationTitleArray = array();

The assignment to $productCombinationTitleArray is dead and can be removed.

                            if (isset($product['product_combination_title']) and is_array($product['product_combination_title'])) {
                                foreach ($product['product_combination_title'] as $key => $val) {
                                    $productCombinationTitle[] = $key.': '.$val;
                                }

                                $product['product_attribute_title'] = implode(', ', $productCombinationTitle);

The variable $productCombinationTitle does not seem to be defined for all execution paths leading up to this point.

                            }
                        }

                        $products[] = new InvoiceRule($product);
                    }

                    if ($order->orderSendingMethod) {
                        $invoiceRule = array(
                            'type' => 'sending_cost',
                            'title' => $order->orderSendingMethod->title,
                            'tax_rate_id' =>  $order->orderSendingMethod->tax_rate_id,
                            'tax_rate' =>  $order->orderSendingMethod->tax_rate,
                            'amount' =>  1,
                            'price_with_tax' =>  $order->orderSendingMethod->price_with_tax,
                            'price_without_tax' =>  $order->orderSendingMethod->price_without_tax,
                            'total_price_with_tax' =>  $order->orderSendingMethod->price_with_tax,
                            'total_price_without_tax' =>  $order->orderSendingMethod->price_without_tax,
                        );

                        $products[] = new InvoiceRule($invoiceRule);
                    }

                    if ($order->orderPaymentMethod) {
                        $invoiceRule = array(
                            'type' => 'payment_cost',
                            'title' => $order->orderPaymentMethod->title,
                            'tax_rate_id' =>  $order->orderPaymentMethod->tax_rate_id,
                            'tax_rate' =>  $order->orderPaymentMethod->tax_rate,
                            'amount' =>  1,
                            'price_with_tax' =>  $order->orderPaymentMethod->price_with_tax,
                            'price_without_tax' =>  $order->orderPaymentMethod->price_without_tax,
                            'total_price_with_tax' =>  $order->orderPaymentMethod->price_with_tax,
                            'total_price_without_tax' =>  $order->orderPaymentMethod->price_without_tax,
                        );

                        $products[] = new InvoiceRule($invoiceRule);
                    }

                    $this->model->products()->saveMany($products);

The variable $products seems to be defined by a foreach iteration on line 87. Are you sure the iterator is never empty, otherwise this variable is not defined?

                }

                if ($order->orderBillAddress and $order->orderDeliveryAddress) {
                    $deliveryInvoiceAddress = new InvoiceAddress($order->orderBillAddress->toArray());
       
                    $billInvoiceAddress = new InvoiceAddress($order->orderDeliveryAddress->toArray());

                    $this->model->invoiceAddress()->saveMany(array($deliveryInvoiceAddress, $billInvoiceAddress));
     
                    $this->model->fill(array('delivery_invoice_address_id' => $deliveryInvoiceAddress->id, 'bill_invoice_address_id' => $billInvoiceAddress->id));
                    $this->model->save();
                }
            }

            return $this->model;
        }