Hideyo\Ecommerce\Framework\Services\TaxRate\TaxRateService

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	rules()	0	12	2
A	create()	0	11	2
A	updateById()	0	11	2

<?php

namespace Hideyo\Ecommerce\Framework\Services\TaxRate;

use Validator;
use Hideyo\Ecommerce\Framework\Services\TaxRate\Entity\TaxRateRepository;
use Hideyo\Ecommerce\Framework\Services\BaseService;
 
class TaxRateService extends BaseService
{
	public function __construct(TaxRateRepository $taxRate)
	{
		$this->repo = $taxRate;

The property repo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

	} 

    /**
     * The validation rules for the model.
     *
     * @param  integer  $taxRateId id attribute model    
     * @return array
     */
    public function rules($taxRateId = false)
    {
        $rules = array(
            'title' => 'required|between:2,65|unique_with:'.$this->repo->getModel()->getTable().', shop_id',
            'rate'  => 'numeric|required'
        );
        
        if($taxRateId) {

The expression $taxRateId of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

            $rules['title'] =   $rules['title'].','.$taxRateId.' = id';
        }

        return $rules;
    } 

    /**
     * create model
     * @param  array  $attributes 
     * @return mixed         
     */
    public function create(array $attributes)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules());

        if ($validator->fails()) {
            return $validator;
        }

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return $this->updateOrAddModel($this->repo->getModel(), $attributes);
    }

    /**
     * update model by id
     * @param  array  $attributes 
     * @param  integer $taxRateId         
     * @return mixed            
     */
    public function updateById(array $attributes, $taxRateId)

The parameter $taxRateId is not used and could be removed.

    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules($id));

The variable $id seems to be never defined.

        if ($validator->fails()) {
            return $validator;
        }

        $model = $this->find($id);
        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return $this->updateOrAddModel($model, $attributes);
    } 
	
}