Hideyo\Ecommerce\Framework\Services\Shop\ShopService

Complexity

Total Complexity

20

Size/Duplication

Total Lines	148
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	findUrl()	0	9	2
A	create()	0	32	6
A	destroy()	0	11	1
A	__construct()	0	5	1
A	updateEntity()	0	33	6
A	rules()	0	12	2
A	updateById()	0	10	2

<?php

namespace Hideyo\Ecommerce\Framework\Services\Shop;

use Validator;
use File;
use Image;
use Hideyo\Ecommerce\Framework\Services\Shop\Entity\ShopRepository;
use Hideyo\Ecommerce\Framework\Services\BaseService;
 
class ShopService extends BaseService
{
    public function __construct(ShopRepository $shop)
    {
        $this->repo = $shop;

The property repo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->storageImagePath = storage_path() .config('hideyo.storage_path'). "/shop/";

The property storageImagePath does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->publicImagePath = public_path() .config('hideyo.public_path'). "/shop/";

The property publicImagePath does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    } 

    /**
     * The validation rules for the model.
     *
     * @param  integer  $shopId id attribute model    
     * @return array
     */
    private function rules($shopId = false)
    {
        $rules = array(
            'title' => 'required|between:4,65|unique:'.$this->repo->getModel()->getTable(),
            'active' => 'required'
        );

        if ($shopId) {

The expression $shopId of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

            $rules['title'] =   $rules['title'].',title,'.$shopId;
        }

        return $rules;
    }

    public function create(array $attributes)
    {
        $validator = Validator::make($attributes, $this->rules());

        if ($validator->fails()) {
            return $validator;
        }
        $model = $this->updateOrAddModel($this->repo->getModel(), $attributes);
        
        if (isset($attributes['logo'])) {
            $destinationPath = $this->storageImagePath.$model->id;
            $filename =  str_replace(" ", "_", strtolower($attributes['logo']->getClientOriginalName()));
            $upload_success = $attributes['logo']->move($destinationPath, $filename);

            $attributes['logo_file_name'] = $filename;
            $attributes['logo_file_path'] = $upload_success->getRealPath();
            $model = $this->updateOrAddModel($model, $attributes);

            if (File::exists($model->logo_file_path)) {
                if (!File::exists($this->publicImagePath.$model->id)) {
                    File::makeDirectory($this->publicImagePath.$model->id, 0777, true);
                }

                if (!File::exists($this->publicImagePath.$model->id."/".$model->logo_file_name)) {
                    $image = Image::make($model->logo_file_path);
                    $image->interlace();
                    $image->save($this->publicImagePath.$model->id."/".$model->logo_file_name);
                }
            }
        }
        
        return $model;
    }

    /**
     * update model by id
     * @param  array  $attributes 
     * @param  integer $shopId     
     * @return midex             

The type Hideyo\Ecommerce\Framework\Services\Shop\midex was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function updateById(array $attributes, $shopId)
    {
        $validator = Validator::make($attributes, $this->rules($shopId));

        if ($validator->fails()) {
            return $validator;

The expression return $validator returns the type Illuminate\Contracts\Validation\Validator which is incompatible with the documented return type Hideyo\Ecommerce\Framework\Services\Shop\midex.

        }

        $model = $this->find($shopId);
        return $this->updateEntity($model, $attributes);
    }

    public function updateEntity($model, array $attributes = array())
    {
        if (count($attributes) > 0) {
            if (isset($attributes['logo'])) {
                File::delete($model->logo_file_path);
                $destinationPath = $this->storageImagePath.$model->id;

                $filename =  str_replace(" ", "_", strtolower($attributes['logo']->getClientOriginalName()));
                $upload_success = $attributes['logo']->move($destinationPath, $filename);

                $attributes['logo_file_name'] = $filename;
                $attributes['logo_file_path'] = $upload_success->getRealPath();
            }


            $model->slug = null;
            $model->fill($attributes);
            $model->save();

            if (File::exists($model->logo_file_path)) {
                if (!File::exists($this->publicImagePath.$model->id)) {
                    File::makeDirectory($this->publicImagePath.$model->id, 0777, true);
                }

                if (!File::exists($this->publicImagePath.$model->id."/".$model->logo_file_name)) {
                    $image = Image::make($model->logo_file_path);
                    $image->interlace();
                    $image->save($this->publicImagePath.$model->id."/".$model->logo_file_name);
                }
            }
        }

        return $model;
    }

    /**
     * destroy model
     * @param  integer $shopId 
     * @return object      
     */
    public function destroy($shopId)
    {
        $model = $this->find($shopId);

        File::deleteDirectory($this->publicImagePath.$model->id);
        $destinationPath = $this->storageImagePath.$model->id;
        File::deleteDirectory($destinationPath);
        
        $model->save();

        return $model->delete();
    }

    /**
     * find model by url
     * @param  string $shopUrl 
     * @return mixed
     */
    public function findUrl($shopUrl)
    {
        $result = $this->repo->findUrl($shopUrl);

        if (isset($result->id)) {
            return $result;
        }
        
        return false;      
    }
}