Hideyo\Ecommerce\Framework\Services\Redirect\RedirectService

Complexity

Total Complexity

17

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	updateClicks()	0	9	2
A	importCsv()	0	34	5
A	findByUrl()	0	3	1
A	__construct()	0	3	1
A	rules()	0	11	2
A	updateById()	0	16	3
A	create()	0	13	2
A	findByUrlAndActive()	0	3	1

<?php

namespace Hideyo\Ecommerce\Framework\Services\Redirect;

use Validator;
use File;
use Hideyo\Ecommerce\Framework\Services\Redirect\Entity\RedirectRepository;
use Hideyo\Ecommerce\Framework\Services\BaseService;
 
class RedirectService extends BaseService
{
	public function __construct(RedirectRepository $taxRate)
	{
		$this->repo = $taxRate;

The property repo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

	} 

    /**
     * The validation rules for the model.
     *
     * @param  integer  $redirectId id attribute model    
     * @return array
     */
    public function rules($redirectId = false)
    {
        $rules = array(
            'url' => 'required|unique_with:'.$this->repo->getModel()->getTable().', shop_id'
        );
        
        if ($redirectId) {

The expression $redirectId of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

            $rules['url'] = 'required|unique_with:'.$this->repo->getModel()->getTable().', shop_id, '.$redirectId.' = id';
        }

        return $rules;
    }

    public function create(array $attributes)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules());

        if ($validator->fails()) {
            return $validator;
        }

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->repo->getModel()->fill($attributes);
        $this->repo->getModel()->save();
        return $this->repo->getModel();
    }

    public function updateById(array $attributes, $id)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules($id));
        if ($validator->fails()) {
            return $validator;
        }

        $model = $this->find($id);
        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if (count($attributes) > 0) {
            $model->fill($attributes);
            $model->save();
        }
        return $model;  
    } 

    public function importCsv($results, $shopId)
    {
        foreach ($results as $row) {

            $attributes = $row->toArray();
            $attributes['shop_id'] = $shopId;
            $attributes['active'] = 0;
     
            $validator = Validator::make($attributes, $this->rules());

            if ($validator->fails()) {
    
                $result = $this->repo->getModel()->where('url', '=', $attributes['url'])->get()->first();
                if ($result) {
                    $attributes['active'] = 0;
                    if($attributes['redirect_url']) {
                        $attributes['active'] = 1;
                    } 
                    $model = $this->find($result->id);
		            $model->fill($attributes);
		            $model->save();

		            return $model;
                }

            } else {
                $redirect = new Redirect;
                $redirect->fill($attributes);
                $redirect->save();
         
            }
        }

        return true;
    }	

    public function updateClicks($url)
    {
        $result = $this->repo->findByUrl($url);
        if ($result) {
            $model = $this->find($result->id);
            $model->fill(array('clicks' => $result->clicks + 1));
            $model->save();

            return $model;

        }
    }

    public function findByUrl($url)
    {
        return $this->repo->findByUrl($url);
    }


    public function findByUrlAndActive($url)
    {
        return $this->repo->findByUrlAndActive($url);
    }


}