Hideyo\Ecommerce\Framework\Services\Product\Entity\ProductExtraFieldValueRepository

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	selectOneByShopIdAndSlug()	0	3	1
A	__construct()	0	4	1
A	selectOneByShopIdAndId()	0	3	1
A	selectByProductIdAndExtraFieldId()	0	4	1
A	selectAllByProductId()	0	3	1
A	selectAllByProductCategoryId()	0	15	1

<?php
namespace Hideyo\Ecommerce\Framework\Services\Product\Entity;
 
use Hideyo\Ecommerce\Framework\Services\Product\Entity\ProductExtraFieldValue;
use Hideyo\Ecommerce\Framework\Services\Product\Entity\ProductRepository;
use Hideyo\Ecommerce\Framework\Services\BaseRepository;
 
class ProductExtraFieldValueRepository extends BaseRepository 
{

    protected $model;

    public function __construct(ProductExtraFieldValue $model, ProductRepository $product)
    {
        $this->model = $model;
        $this->product = $product;

The property product does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
  
 
    public function selectAllByProductId($productId)
    {
        return $this->model->where('shop_id', auth('hideyobackend')->user()->selected_shop_id)->where('product_id', '=', $productId)->get();

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function selectByProductIdAndExtraFieldId($productId, $extraFieldId)
    {

        return $this->model->where('shop_id', auth('hideyobackend')->user()->selected_shop_id)->where('product_id', '=', $productId)->where('extra_field_id', '=', $extraFieldId)->get();

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    function selectOneByShopIdAndSlug($shopId, $slug)

It is generally recommended to explicitly declare the visibility for methods.

    {
           return $this->model->with(array('productCategory', 'productImages'))->where('shop_id', $shopId)->where('slug', $slug)->get()->first();
    }

    function selectOneByShopIdAndId($shopId, $id)

It is generally recommended to explicitly declare the visibility for methods.

    {
           return $this->model->with(array('productCategory', 'productImages'))->where('shop_id', $shopId)->where('id', $id)->get()->first();
    }

    function selectAllByProductCategoryId($productCategoryId, $shopId)

It is generally recommended to explicitly declare the visibility for methods.

    {

         return $this->model->
         whereHas('product', function ($query) use ($productCategoryId, $shopId) {
            $query->where('product_category_id', '=', $productCategoryId);
            $query->where('active', 1);
            $query->where('shop_id', $shopId);
         })->with(
             array(
                'extraFieldDefaultValue',
                'extraField' => function ($q) {

The parameter $q is not used and could be removed.

                }
                )
         )->get();
    }
}