Hideyo\Ecommerce\Framework\Services\PaymentMethod\PaymentMethodService

Complexity

Total Complexity

9

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	selectOneByShopIdAndId()	0	8	2
A	rules()	0	12	2
A	create()	0	10	2
A	updateById()	0	12	2
A	__construct()	0	3	1

<?php

namespace Hideyo\Ecommerce\Framework\Services\PaymentMethod;

use Validator;
use File;
use Hideyo\Ecommerce\Framework\Services\PaymentMethod\Entity\PaymentMethodRepository;
use Hideyo\Ecommerce\Framework\Services\BaseService;
 
class PaymentMethodService extends BaseService
{
	public function __construct(PaymentMethodRepository $paymentMethod)
	{
		$this->repo = $paymentMethod;

The property repo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

	}

    public function selectOneByShopIdAndId($shopId, $paymentMethodId)
    {
    	$result = $this->repo->selectOneByShopIdAndId($shopId, $paymentMethodId);

        if ($result->isEmpty()) {
            return false;
        }
        return $result->first();

    }

    /**
     * The validation rules for the model.
     *
     * @param  integer  $paymentMethodId id attribute model    
     * @return array
     */
    private function rules($paymentMethodId = false)
    {
        $rules = array(
            'title' => 'required|between:4,65|unique_with:'.$this->repo->getModel()->getTable().', shop_id',
            'price'  => 'numeric|required'
        );
        
        if ($paymentMethodId) {

The expression $paymentMethodId of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

            $rules['title'] =   $rules['title'].','.$paymentMethodId.' = id';
        }

        return $rules;
    }
  
    public function create(array $attributes)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules());

        if ($validator->fails()) {
            return $validator;
        }
        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return $this->updateOrAddModel($this->repo->getModel(), $attributes);
    }

    public function updateById(array $attributes, $paymentMethodId)
    {
        $model = $this->find($paymentMethodId);
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;        

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules($paymentMethodId));

        if ($validator->fails()) {
            return $validator;
        }

        return $this->updateOrAddModel($model, $attributes);
    }
}