Hideyo\Ecommerce\Framework\Services\HtmlBlock\HtmlBlockService

Complexity

Total Complexity

39

Size/Duplication

Total Lines	262
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	0	11	2
B	updateEntity()	0	60	10
A	updateById()	0	11	2
A	findByPosition()	0	9	2
A	changeActive()	0	23	3
A	selectOneByShopIdAndPosition()	0	2	1
A	createCopy()	0	18	2
A	destroy()	0	11	1
C	create()	0	69	12
A	__construct()	0	5	1
A	selectAllActiveGroupsByShopId()	0	3	1
A	selectByLimitAndOrderBy()	0	3	1
A	selectOneBySlug()	0	3	1

<?php

namespace Hideyo\Ecommerce\Framework\Services\HtmlBlock;

use Validator;
use File;
use DbView;

The type DbView was not found. Maybe you did not declare it correctly or list all dependencies?

use Hideyo\Ecommerce\Framework\Services\HtmlBlock\Entity\HtmlBlockRepository;
use Hideyo\Ecommerce\Framework\Services\BaseService;
use Hideyo\Ecommerce\Framework\Services\Shop\ShopFacade as ShopService;
 
class HtmlBlockService extends BaseService
{
	public function __construct(HtmlBlockRepository $htmlBlock)
	{
		$this->repo = $htmlBlock;

The property repo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->storageImagePath = storage_path() .config('hideyo.storage_path'). "/html_block/";

The property storageImagePath does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->publicImagePath = public_path() .config('hideyo.public_path'). "/html_block/";

The property publicImagePath does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

	} 

   /**
     * The validation rules for the model.
     *
     * @param  integer  $htmlBlockId id attribute model    
     * @return array
     */
    public function rules($htmlBlockId = false, $attributes = false)

The parameter $attributes is not used and could be removed.

    {
        $rules = array(
            'title'                 => 'required|between:4,65'
        );
        
        if ($htmlBlockId) {

The expression $htmlBlockId of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

            $rules['title'] =   'required|between:4,65';
        }
  
        return $rules;
    }
  
    public function create(array $attributes)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules());

        if ($validator->fails()) {
            return $validator;
        }

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;            

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

      
        $this->model->fill($attributes);
        $this->model->save();

        if (isset($attributes['image'])) {
            $attributes['image_file_extension'] = $attributes['image']->getClientOriginalExtension();
            $attributes['image_file_size'] = $attributes['image']->getSize();

            $rules = array(
                'file'=>'image|max:1000'
            );

            $validator = Validator::make($attributes, $rules);

            if ($validator->fails()) {
                return $validator;
            } else {
                $destinationPath = $this->storageImagePath.$this->model->id;
                $filename =  str_replace(" ", "_", strtolower($attributes['image']->getClientOriginalName()));
                $uploadSuccess = $attributes['image']->move($destinationPath, $filename);

                if ($uploadSuccess) {
                    $attributes['image_file_name'] = $filename;
                    $attributes['image_file_path'] = $uploadSuccess->getRealPath();

                    $this->model->fill($attributes);
                    $this->model->save();

                    if ($this->model->thumbnail_height and $this->model->thumbnail_width) {
                        $image = Image::make($uploadSuccess->getRealPath());

The type Hideyo\Ecommerce\Framework\Services\HtmlBlock\Image was not found. Maybe you did not declare it correctly or list all dependencies?

               
                        $image->resize($this->model->thumbnail_width, $this->model->thumbnail_height);
                        $image->interlace();

                        if (!File::exists($this->publicImagePath.$this->model->id."/")) {
                            File::makeDirectory($this->publicImagePath.$this->model->id."/", 0777, true);
                        }
                        $image->save($this->publicImagePath.$this->model->id."/".$filename);
                    }
                }
            }
        }


        if ($this->model->thumbnail_height and $this->model->thumbnail_width and $this->model->image_file_name) {
            File::deleteDirectory($this->publicImagePath.$this->model->id."/");
            $image = Image::make($this->model->image_file_path);
   
            $image->resize($this->model->thumbnail_width, $this->model->thumbnail_height);
            $image->interlace();

            if (!File::exists($this->publicImagePath.$this->model->id."/")) {
                File::makeDirectory($this->publicImagePath.$this->model->id."/", 0777, true);
            }
            $image->save($this->publicImagePath.$this->model->id."/".$this->model->image_file_name);
        }

   
        return $this->model;
    }

    public function createCopy(array $attributes, $htmlBlockId)
    {
        $product =  $this->find($htmlBlockId);

The assignment to $product is dead and can be removed.

        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules());

        if ($validator->fails()) {
            return $validator;
        }
   
        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->sluggify();
        $this->model->fill($attributes);

        $this->model->save();
    
        return $this->model;
    }

    public function changeActive($htmlBlockId)
    {
        $this->model = $this->find($htmlBlockId);

The property model does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if ($this->model) {
            $active = 1;
            
            if ($this->model->active) {
                $active = 0;
            }

            $attributes = array(
                'active' => $active
            );

            $this->model->fill($attributes);

            $this->model->sluggify();

            return $this->model->save();
        }

        return false;
    }



    public function updateById(array $attributes, $htmlBlockId)
    {
        $validator = Validator::make($attributes, $this->rules($htmlBlockId, $attributes));

        if ($validator->fails()) {
            return $validator;
        }

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model = $this->find($htmlBlockId);

The property model does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->updateEntity($attributes);
    }

    public function updateEntity(array $attributes = array())
    {

        $shopId = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $shop = ShopService::find($shopId);

The assignment to $shop is dead and can be removed.

        if (count($attributes) > 0) {
            $this->model->fill($attributes);
            $this->model->save();
        }


        if (isset($attributes['image'])) {
            $attributes['image_file_extension'] = $attributes['image']->getClientOriginalExtension();
            $attributes['image_file_size'] = $attributes['image']->getSize();


            $rules = array(
                'file'=>'image|max:1000'
            );

            $validator = Validator::make($attributes, $rules);

            if ($validator->fails()) {
                return $validator;
            } else {
                $destinationPath = $this->storageImagePath.$this->model->id;
                $filename =  str_replace(" ", "_", strtolower($attributes['image']->getClientOriginalName()));
                File::deleteDirectory($destinationPath);

                $uploadSuccess = $attributes['image']->move($destinationPath, $filename);

                if ($uploadSuccess) {
                    $attributes['image_file_name'] = $filename;
                    $attributes['image_file_path'] = $uploadSuccess->getRealPath();

                    $this->model->fill($attributes);
                    $this->model->save();
                }
            }
        }
 
        if (File::exists($this->model->image_file_path) AND $this->model->thumbnail_height and $this->model->thumbnail_width and $this->model->image_file_name) {
            $image = Image::make($this->model->image_file_path);
   

            File::deleteDirectory($this->publicImagePath.$this->model->id);


            $image->resize($this->model->thumbnail_width, $this->model->thumbnail_height);
            $image->interlace();

            if (!File::exists($this->publicImagePath.$this->model->id."/")) {
                File::makeDirectory($this->publicImagePath.$this->model->id."/", 0777, true);
            }
            $image->save($this->publicImagePath.$this->model->id."/".$this->model->image_file_name);
        }


        return $this->model;
    }

    public function destroy($htmlBlockId)
    {
        $this->model = $this->find($htmlBlockId);

The property model does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        File::deleteDirectory($this->publicImagePath.$this->model->id);

        $destinationPath = $this->storageImagePath.$this->model->id;

        File::deleteDirectory($destinationPath);
        $this->model->save();

The method save() does not exist on null.

        return $this->model->delete();
    }

    public function selectByLimitAndOrderBy($shopId, $limit, $orderBy)
    {
    	return $this->repo->selectByLimitAndOrderBy($shopId, $limit, $orderBy);

The method selectByLimitAndOrderBy() does not exist on Hideyo\Ecommerce\Framework\Services\HtmlBlock\Entity\HtmlBlockRepository.

    }

    public function selectOneBySlug($shopId, $slug)
    {
    	return $this->repo->selectOneBySlug($shopId, $slug);

The method selectOneBySlug() does not exist on Hideyo\Ecommerce\Framework\Services\HtmlBlock\Entity\HtmlBlockRepository. Did you maybe mean selectOneByShopIdAndSlug()?

    }

    public function selectAllActiveGroupsByShopId($shopId)
    {
    	return $this->repo->selectAllActiveGroupsByShopId($shopId);

The method selectAllActiveGroupsByShopId() does not exist on Hideyo\Ecommerce\Framework\Services\HtmlBlock\Entity\HtmlBlockRepository. Did you maybe mean selectAll()?

    }

    public function selectOneByShopIdAndPosition($position, $shopId) {
        return $this->repo->selectOneByShopIdAndPosition($position, $shopId);
    }

    public function findByPosition($position)
    {
        $result = $this->repo->selectOneByShopIdAndPosition($position, config()->get('app.shop_id'));
        
        if ($result) {
            return DbView::make($result)->with($result->toArray())->render();
        }
        
        return '';        
    }
}