Hideyo\Ecommerce\Framework\Services\Client\Entity\ClientRepository

Complexity

Total Complexity

15

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	selectAllByBillClientAddress()	0	5	1
A	findByEmail()	0	3	1
A	getClientByConfirmationCode()	0	3	1
A	selectOneByShopIdAndId()	0	3	1
A	selectOneById()	0	3	1
A	checkEmailByShopIdAndNoAccountCreated()	0	2	1
A	validateRegisterNoAccount()	0	9	2
A	checkEmailByShopId()	0	3	1
A	validateConfirmationCodeByConfirmationCodeAndEmail()	0	8	1
A	selectAll()	0	3	1
A	editAddress()	0	3	1
A	validateConfirmationCodeByConfirmationCodeAndNewEmail()	0	8	1
A	selectAllExport()	0	3	1

<?php 

namespace Hideyo\Ecommerce\Framework\Services\Client\Entity;

use Hideyo\Ecommerce\Framework\Services\Client\Entity\Client;
use Hideyo\Ecommerce\Framework\Services\Client\Entity\ClientAddressRepository;
use Hideyo\Ecommerce\Framework\Services\BaseRepository;

class ClientRepository extends BaseRepository 
{
    protected $model;

    public function __construct(Client $model, ClientAddressRepository $clientAddress)
    {
        $this->model = $model;
        $this->clientAddress = $clientAddress;

The property clientAddress does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function selectAll()
    {
        return $this->model->where('shop_id', auth('hideyobackend')->user()->selected_shop_id)->get();

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function selectAllByBillClientAddress()
    {
        return $this->model->selectRaw('CONCAT(client_address.firstname, " ", client_address.lastname) as fullname, client_address.*, client.id')
        ->leftJoin('client_address', 'client.bill_client_address_id', '=', 'client_address.id')->where('shop_id', auth('hideyobackend')->user()->selected_shop_id)

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        ->get();
    }

    public function findByEmail($email, $shopId)
    {
        return $this->model->where('shop_id', $shopId)->where('email', '=', $email)->get()->first();
    }

    public function checkEmailByShopIdAndNoAccountCreated($email, $shopId) {
        return $this->model->where('shop_id', $shopId)->whereNotNull('account_created')->where('email', '=', $email)->get()->first();
    }

    public function checkEmailByShopId($email, $shopId)
    {
        return $this->model->where('shop_id', $shopId)->where('email', '=', $email)->get()->first();
    }

    public function validateRegisterNoAccount(array $attributes, $shopId)
    {
        $client = $this->model->where('shop_id', $shopId)->where('email', '=', $attributes['email'])->get()->first();

        if ($client) {
            return false;
        }

        return true;
    }

    public function selectOneByShopIdAndId($shopId, $clientId)
    {
        return $this->model->with(array('clientAddress', 'clientDeliveryAddress', 'clientBillAddress'))->where('shop_id', $shopId)->where('active', 1)->where('id', '=', $clientId)->first();
    }

    public function selectOneById($clientId)
    {
        return $this->model->with(array('clientAddress', 'clientDeliveryAddress', 'clientBillAddress'))->where('shop_id', auth('hideyobackend')->user()->selected_shop_id)->where('active', 1)->where('id', '=', $clientId)->first();

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function getClientByConfirmationCode($shopId, $email, $confirmationCode)
    {
        return $this->model->where('shop_id', $shopId)->where('email', '=', $email)->where('confirmation_code', '=', $confirmationCode)->get()->first();
    }

    public function validateConfirmationCodeByConfirmationCodeAndEmail($confirmationCode, $email, $shopId)
    {
        return $this->model
        ->where('shop_id', $shopId)
        ->where('email', '=', $email)
        ->whereNotNull('account_created')
        ->where('confirmation_code', '=', $confirmationCode)
        ->get()->first();
    }

    public function validateConfirmationCodeByConfirmationCodeAndNewEmail($confirmationCode, $newEmail, $shopId)
    {
        return $this->model
        ->where('shop_id', $shopId)
        ->where('new_email', '=', $newEmail)
        ->whereNotNull('account_created')
        ->where('confirmation_code', '=', $confirmationCode)
        ->get()->first();
    }

    public function selectAllExport()
    {
        return $this->model->with(array('clientAddress', 'clientDeliveryAddress', 'clientBillAddress'))->whereNotNull('account_created')->where('active', 1)->where('shop_id', auth('hideyobackend')->user()->selected_shop_id)->get();

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function editAddress($shopId, $clientId, $addressId, $attributes)
    {
        return $this->clientAddress->updateByIdAndShopId($shopId, $attributes, $clientId, $addressId);

The method updateByIdAndShopId() does not exist on Hideyo\Ecommerce\Framework\Services\Client\Entity\ClientAddressRepository.

    }
}